GNOME Bugzilla – Bug 588471
Orca's clicking functionality should click on the locusOfFocus when not in flat review
Last modified: 2009-11-09 21:35:29 UTC
In working on possible solutions for the mouseover support bug (bug 586399), I came across a problem with our clicking functionality: Sometimes we cannot figure out our current position with respect to the flat review context. For example: Steps to reproduce: 1. Tab to the "Friends" link/menu in Facebook 2. Without activating flat review press NumPad Slash to left click on friends or NumPad Multiply to right click on it. Expected results: The click would occur on Friends Actual results: The click occurs on the File menu because of a Gecko bug that is preventing us from figuring out where we are. One possible solution would be to do something similar to what I implemented for RFE/Bug 588403 (Implement ability to route the mouse pointer without clicking). There, if we have a flat review context, we route to our position in flat review; if we don't have a flat review context, we route to our position in focus tracking mode (i.e. the locusOfFocus). Were we to do something like this for clicking, I believe the user experience would be more as expected -- even in the face of other people's bugs. Thoughts? BTW, I'm blocking bug 586399 - mouseover support -- against this one. With the Facebook friends menu, the stupid thing doesn't seem to be keyboard usable: even if I position you in the menu and you arrow up and down amongst the menu items, the only way to chose a menu item is to physically perform a click on it. When you go to click on it using Orca's clicking functionality, you click on the File menu.
Personally This sounds like a good approach to me.
I was chatting briefly with Will about this. He said, "We'll need to ask users. Right now, we enter flat review automatically when one does the click operation." I am happy to ask the users. However it raised a question: Any time I am not in flat review and I click using Orca, I do not wind up in flat review; I click. A menu might appear (context or File); nothing observable might happen (if I left-click on say the text I'm reading in Evolution). The one thing -- in my experience which does not occur is entering flat review. Mike: Should we be entering flat review in this case? If so, we should open a new bug.
I feel strongly that we should not enter flat review in this case.
Created attachment 138645 [details] [review] proposed patch Will, please review. Thanks!
(In reply to comment #4) > Created an attachment (id=138645) [edit] > proposed patch > > Will, please review. Thanks! Looks awesome. Thanks!
Thanks Will. Patch committed to master. Closing as FIXED.