Created attachment 138253 [details] [review]
fix build failure

Ping. The rationale here is that PTHREAD_MUTEX_RECURSIVE_NP is an enum on kFreeBSD, and not a define, so a previous change to fix Hurd broke kFreeBSD.

OK to commit?

Disagree, we should still detect if PTHREAD_MUTEX_RECURSIVE_NP 
is defined as a macro and just || for that specific system OS.
Suggest another patch along those lines please,

Daniel

Created attachment 150066 [details] [review]
Use PTHREAD_MUTEX_RECURSIVE_NP on kFreeBSD

(In reply to comment #3)
> Disagree, we should still detect if PTHREAD_MUTEX_RECURSIVE_NP 
> is defined as a macro and just || for that specific system OS.
> Suggest another patch along those lines please,

Sure, how does this one look?

Also I wonder if the check for linux instead of __linux__ is correct...

Created attachment 156935 [details] [review]
configure checks for PTHREAD_MUTEX_RECURSIVE_NP and PTHREAD_MUTEX_RECURSIVE

This patch provides configure checks for PTHREAD_MUTEX_RECURSIVE_NP and PTHREAD_MUTEX_RECURSIVE, by checking whether they can be used in code.
If PTHREAD_MUTEX_RECURSIVE_NP is found it used, otherwise if PTHREAD_MUTEX_RECURSIVE it is used, and if none of both is available, it errors out.

Produced against current git/master, successfully tested under GNU/Linux and GNU/Hurd.

Ping? Can we commit this? The patch looks good to me. It's much better to check for features in configure.ac this way than trying to list every system in the code. OK to commit?

gamin is not under active development anymore and has not seen code changes for many years.
Its codebase has been archived: https://gitlab.gnome.org/Archive/gamin/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.