After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588266 - Add support for cbt files
Add support for cbt files
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: backends
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-10 17:24 UTC by Juanjo Marín
Modified: 2009-12-11 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[comics] Support for cbt format (3.14 KB, patch)
2009-07-11 12:02 UTC, Juanjo Marín 		reviewed Details | Review
Patch modified for being applied on master (3.47 KB, patch)
2009-12-10 20:58 UTC, Juanjo Marín 		committed Details | Review

Description Juanjo Marín 2009-07-10 17:24:20 UTC 
Please describe the problem:
Add support for cbt files in the comics backend. Feature request from Paulo  the mailing list [1]

[1] http://mail.gnome.org/archives/evince-list/2009-July/msg00001.html

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Juanjo Marín 2009-07-11 12:02:58 UTC 
Created attachment 138239 [details] [review]
[comics] Support for cbt format

This is my patch for adding cbt support. I only left to send a patch to mime-share-info for adding the mimte type application/x-cbt.
Comment 2 Juanjo Marín 2009-07-11 16:28:55 UTC 
Created bug for adding cbt support on shared-mime-info [1]. Sent patch.

[1]https://bugs.freedesktop.org/show_bug.cgi?id=22724
Comment 3 Carlos Garcia Campos 2009-07-12 10:17:57 UTC 
Ok, let's wait until shared-mime-info is fixed then.
Comment 4 Juanjo Marín 2009-10-06 13:01:56 UTC 
shared-mime-info has added cbt files on its database

[1]https://bugs.freedesktop.org/show_bug.cgi?id=22724
Comment 5 Juanjo Marín 2009-12-09 23:29:34 UTC 
The first tar file of shared-mime-info is

shared-mime-info-0.70.tar.bz2
Comment 6 Juanjo Marín 2009-12-10 20:58:56 UTC 
Created attachment 149544 [details] [review]
Patch modified for being applied on master

Ready for being reviewed and applied !
Comment 7 Carlos Garcia Campos 2009-12-11 13:42:05 UTC 
Review of attachment 149544 [details] [review]:

Applied to git master, thanks!