GNOME Bugzilla – Bug 588091
gnome-schedule crashed on startup after upgrade frrom 2.02 to 2.1
Last modified: 2009-11-01 00:06:08 UTC
Steps to reproduce: 1. create a one time scheduled task in 2.02 2. uninstall 2.02 and install 2.1 3. start up gnome-schedule Stack trace: Traceback (most recent call last): File "/usr/local/share/gnome-schedule/gnome-schedule.py", line 74, in <module> mainWindow = mainWindow.main(debug_flag, False, pr, manual_poscorrect)
+ Trace 216358
self.schedule_reload ()
data = self.crontab.read ()
array_or_false = self.parse (line)
success, ver, title, desc, output, display, command_d = self.get_job_data (job_id)
return True, ver, title, desc, output, display, command_d
Other information: i was able to fix this bug by adding this to line 645 of crontab.py: display = 0 command_d = "" sorry I have never created a patch file. here is what my crontab file looked like ---------------------------------------- /root/.gnome/gnome-schedule/crontab/1 ---------------------------------------- ver=3 title=Sync time desc= nooutput=1 ----------------------------------------
Created attachment 138049 [details] [review] Patch for 2.1.0 here we are
Thanks! I have committed a slightly modified version of your fix. Patches: Since Gnome-schedule uses the git VCS the best to do is to do a clone of the repository and then use git format-patch to create a patch: $ git clone git://git.gnome.org/gnome-schedule do changes $ git add files $ git commit $ git format-patch -1 (-1 is for the last commit, use -2 if you have two commits - one is preferred) then your name will show up in the history of the commit and you'll get the credit :) thanks, gaute
i did notice one other issue .. theres a type mismatch (i haven't checked for an error or not but I just visually noticed it) .. at line 693 of crontab.py: return True, ver, title, desc, output, display, command_d else: return False, "", "", "", 0, 0, "" the return false has display as 0 (numeric) where it is a string above .. i don't really know python and i'm not sure how the type juggling works, but just an fyi
(In reply to comment #3) > at line 693 of crontab.py: > return True, ver, title, desc, output, display, command_d > else: > return False, "", "", "", 0, 0, "" > the return false has display as 0 (numeric) where it is a string above .. i > don't really know python and i'm not sure how the type juggling works, but just > an fyi thanks! i'll fix that too! - gaute
Done! http://git.gnome.org/cgit/gnome-schedule/commit/?id=e0b8db2ec9fb54d72425e4cabc6aa52ee5fd8228 Got a bit mixed with whitespace cleanup, but should be right now. In fact the various wrong types never got used since the first False variable stopped any other functions using the results. - gaute
*** Bug 600245 has been marked as a duplicate of this bug. ***
See launchpad bug: lp:419471 https://bugs.launchpad.net/ubuntu/+source/gnome-schedule/+bug/419471 The simple fix if you are not able to upgrade to the latest version is described there: > [..] Just deleting the data files should make gnome-schedule use > some default values. They are located in ~/.gnome/gnome-schedule/crontab> > > $ cd ~/.gnome/gnome-schedule/crontab/ && rm * > > In case that doesn't work you could delete your entire crontab > (scheduled recurrent tasks) with: > > $ crontab -d - gaute
*** Bug 600267 has been marked as a duplicate of this bug. ***