GNOME Bugzilla – Bug 588003
No easy way to set album sort artist as the same as the artist but without the articles "the" and "a"
Last modified: 2020-03-17 08:28:16 UTC
http://bugzilla.gnome.org/show_bug.cgi?id=499650 address the issue of artists beginning with "the" being ordered incorrectly in some peoples preference. However if you would like to ignore the "the" you need to change the Sort Album Artist tag. Currently there does not appear to be an easy way to do this. I propose a menu item which when ticked searches the library for all artists beginning with the articles "the" or "a" and automatically updates their metadata so that the sort album artist is the same but without the article. This function should continue to work when new songs are added to the library. When the preference is unticked, the reverse occurs, all sort album artist tags with the expected value are deleted, and any new files added to the library with the expected value are removed. (This allows other values without this format to be retained) This ensures consistency within the library. Perhaps a third option could disable this feature entirely for odd people who don't want consistency!
k
For the sake of correct tags, the sort artist should probably be changed to "artist, article" instead of just "artist", but I agree that there needs to be an easy way to do this.
(In reply to comment #2) > but I agree that there needs to be an easy way to do this. I used to do this manually which worked great... recently imported a new CD and tried to do the same "Artist, The" but Banshee 1.5.3 no longer saves this no matter what I do. Banshee is configured to not store anything inside the media files and the media files are read-only. Regression... worth a new bug?
Created attachment 212900 [details] [review] Patch to populate namesort tag w/o leading "The", "A", etc. This only works when importing files. Existing files would have to be re-imported. If the code is acceptable for use, I will begin coding a handler for existing library entries, so that re-importing is not necessary. Looking for feedback in terms of style, organization, etc. This feature is very common in music players and adds quite a bit of value. There are a disproportionate number of artists who begin with "The", thus currently sorting by artist can lead to undesirable results. Also some users want artists to be sorted w/o a lead "A", while others wish to keep this. With this patch, users can set what leading words (called prefixes) will be removed when auto-populating the artist's namesort field. Thus each user can tailor to their needs. Non-english artists can also use this feature. Thanks!
it seems that you forget to git add src/Core/Banshee.Services/Banshee.Library/TrimmedPrefixes.cs before making the patch. Interesting features. Maybe a Default list get with Catalog.GetString will provide a default list for each language. For example, french: The, A, Un, Une, Les, Le, La Spanish: The, A, El, ... I keep "The, A" in each language because a lot of song title is in english enven in non english spoken country
Review of attachment 212900 [details] [review]: Thanks for the patch! As Olivier mentioned, a file is missing from the patch. And there are some unnecessary changes in translators.xml and the .csproj files. ::: src/Core/Banshee.Services/Banshee.Library/LibrarySchema.cs @@ +98,3 @@ ); + + //WJT - create SchemaEntrys for preferences I don't think that comment is necessary. Please don't prefix comments with your initials. "git blame" can show who wrote what, if we need to find a scape goat ;)
*** Bug 676675 has been marked as a duplicate of this bug. ***
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.