After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587595 - [dshowsrcwrapper] start refactoring
[dshowsrcwrapper] start refactoring
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal enhancement
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2009-07-02 11:53 UTC by Julien Isorce
Modified: 2009-07-21 14:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

move (74.69 KB, patch)
2009-07-02 11:54 UTC, Julien Isorce
none Details | Review
remove gst-libs/gst/dshow from too (81.78 KB, patch)
2009-07-03 08:16 UTC, Julien Isorce
none Details | Review
remove dshow from gst-libs/gst/ too (82.14 KB, patch)
2009-07-03 08:22 UTC, Julien Isorce
none Details | Review

Description Julien Isorce 2009-07-02 11:53:13 UTC
The attached patch remove the gst-libs/gst/dshow
Only Fakesource is moved from gst-libs/gst/dshow to sys/dshowsrcwrapper
Some minor changes (C/C++ check and includes) to make the plugin compile again.

If the patch is accepted I will continue the refactoring:
-remove use of COBJOB macros (C style to C++ style)
-remove gstdshowinterface

And finally I will improve the plugin by adding stuffs frim bug #517203
Comment 1 Julien Isorce 2009-07-02 11:54:26 UTC
Created attachment 137728 [details] [review]
Comment 2 Julien Isorce 2009-07-03 08:16:53 UTC
Created attachment 137769 [details] [review]
remove gst-libs/gst/dshow from too
Comment 3 Julien Isorce 2009-07-03 08:22:32 UTC
Created attachment 137770 [details] [review]
remove dshow from gst-libs/gst/ too
Comment 4 Tim-Philipp Müller 2009-07-20 14:44:10 UTC
Julien: go for it. Feel free to refactor as much as you like, it's -bad after all. Any help with our windows plugins is much appreciated. If someone objects to what you're doing, I'm sure they'll let you know soon enough ;) IIRC that helper lib was never much loved anyway. It'd be nice if the plugin was (still?) buildable with both mingw32 and MSVC afterwards (not sure what the status of that is currently).
Comment 5 Julien Isorce 2009-07-20 16:05:29 UTC
ok I will push the changes although I am not sure I can (access).

About mingw32, there is a non-official directx9c package for mingw32 and
not available from the mingw download repository.
I have already used it and it works pretty well except for the base classes.
For now dshowsrcwrapper depends on bases classes but it should not.
I could try to remove this dependency first.
Anyway I keep this task in mind.
Comment 6 David Schleef 2009-07-20 23:56:16 UTC
Last time I checked, it looked like a huge task to fix the MS base classes to compile with gcc.  I found a project somewhere that attempts to duplicate the functionality of the base classes, but the code wasn't very complete and had a different API.  I attempted briefly to implement things without base classes, but that drove me nuts.
Comment 7 Julien Isorce 2009-07-21 13:58:12 UTC
commit 30469d45c0a9e3f6f0aa361ef0008e313fd07b3f
Author: Julien Isorce <>
Date:   Tue Jul 21 10:49:37 2009 +0200

    start refactoring of dshowsrcwrapper

    -remove gst-libs/gst/dshow
    -fakesource is moved from gst-libs/gst/dshow to sys/dshowsrcwrapper
    -some minor changes (C/C++ check and includes) to make the plugin
    compile again.