GNOME Bugzilla – Bug 587595
[dshowsrcwrapper] start refactoring
Last modified: 2009-07-21 14:11:25 UTC
The attached patch remove the gst-libs/gst/dshow
Only Fakesource is moved from gst-libs/gst/dshow to sys/dshowsrcwrapper
Some minor changes (C/C++ check and includes) to make the plugin compile again.
If the patch is accepted I will continue the refactoring:
-remove use of COBJOB macros (C style to C++ style)
And finally I will improve the plugin by adding stuffs frim bug #517203
Created attachment 137728 [details] [review]
Created attachment 137769 [details] [review]
remove gst-libs/gst/dshow from configure.ac too
Created attachment 137770 [details] [review]
remove dshow from gst-libs/gst/Makefile.am too
Julien: go for it. Feel free to refactor as much as you like, it's -bad after all. Any help with our windows plugins is much appreciated. If someone objects to what you're doing, I'm sure they'll let you know soon enough ;) IIRC that helper lib was never much loved anyway. It'd be nice if the plugin was (still?) buildable with both mingw32 and MSVC afterwards (not sure what the status of that is currently).
ok I will push the changes although I am not sure I can (access).
About mingw32, there is a non-official directx9c package for mingw32 and
not available from the mingw download repository.
I have already used it and it works pretty well except for the base classes.
For now dshowsrcwrapper depends on bases classes but it should not.
I could try to remove this dependency first.
Anyway I keep this task in mind.
Last time I checked, it looked like a huge task to fix the MS base classes to compile with gcc. I found a project somewhere that attempts to duplicate the functionality of the base classes, but the code wasn't very complete and had a different API. I attempted briefly to implement things without base classes, but that drove me nuts.
Author: Julien Isorce <email@example.com>
Date: Tue Jul 21 10:49:37 2009 +0200
start refactoring of dshowsrcwrapper
-fakesource is moved from gst-libs/gst/dshow to sys/dshowsrcwrapper
-some minor changes (C/C++ check and includes) to make the plugin