GNOME Bugzilla – Bug 587470
Smooth scrolling preference doesn't work
Last modified: 2014-03-16 15:59:30 UTC
With WebKit, the smooth scrolling preference has no effect. Scrolling is still discrete.
Created attachment 142519 [details] [review] [PATCH] prefs-dialog: temporarily hide smoothscroll button It is useless right now since we need WebKit support for this. Bug 587470 - Smooth scrolling preference doesn't work --- data/glade/prefs-dialog.glade | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
For some reason the space after Bug when copied to git commit is not precisely a space... weird. Anyway, temp patch to hide this for 2.28.0 release, we can set it visible again later.
(In reply to comment #2) > For some reason the space after Bug when copied to git commit is not precisely > a space... weird. > Anyway, temp patch to hide this for 2.28.0 release, we can set it visible again > later. We are UI frozen now, so we can't do this. What about making it unsensitive?
Yeah, we can do that too I guess. As long as we don't make it usable. Should I do that in master?
(In reply to comment #4) > Yeah, we can do that too I guess. As long as we don't make it usable. Should I > do that in master? Yes please.
Created attachment 142560 [details] [review] [PATCH] prefs-dialog: disable smoothscroll button It is useless right now since we need WebKit support for this. Bug 587470 - Smooth scrolling preference doesn't work --- data/glade/prefs-dialog.glade | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
Created attachment 142561 [details] [review] [PATCH] ephy-dialog: set_sensitivity ignores .ui defaults Bug 587470 - Smooth scrolling preference doesn't work --- lib/ephy-dialog.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
I found a bug in ephy-dialog, it enforces sensitivity ignoring the widget default. Second patch fixes that.
Both patches make sense to me, thanks!
Comment on attachment 142519 [details] [review] [PATCH] prefs-dialog: temporarily hide smoothscroll button oops
Done in master, 4a282e5399a6571f11f646bb766e5fdd57d40850 and 469f9be0c2e48f5c22c8c153dedbba2ffc70c534
Oh sorry, forgot that we need to plug this to webkit support when it's available. Reopening.
So now we have a disabled checkbox that won't do anything? That sounds like seriously bad UI to me. Let's just hide it until support has been added back. Formally working around UI Freeze (but actually making the UI worse) the way it is done now is no solution either imho. Just my €0.02.
(In reply to comment #0) > With WebKit, the smooth scrolling preference has no effect. Scrolling is still > discrete. You probably already know, but just in case... there's a (currently active) WebKit bug about this issue: https://bugs.webkit.org/show_bug.cgi?id=32356
(In reply to comment #13) > So now we have a disabled checkbox that won't do anything? That sounds like > seriously bad UI to me. Let's just hide it until support has been added back. > Formally working around UI Freeze (but actually making the UI worse) the way it > is done now is no solution either imho. Just my €0.02. I've done this now, so 2.32/3.0 won't show the preference unless we manage to fix it.
Does it work now? Thanks.
I mean smooth scrolling, not the option in the preference.
This seems to work in 3.10 at least...