GNOME Bugzilla – Bug 587418
Use accessor functions instead direct access (use GSEAL GnomeGoal)
Last modified: 2010-10-31 16:19:51 UTC
See http://live.gnome.org/GnomeGoals/UseGseal for more details
What functions?
Created attachment 137613 [details] [review] Use accessor functions instead direct access It's a partial patch because there is not accesor functions for GtkObject flags ( See bug #562937 ) and there is not accesor functions for GtkWidget allocations ( See bug #585211 )
Reopening.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
The bug is not fixed as it depends on bug 585391 to get fixed. :-)
Created attachment 141059 [details] [review] Use accessor functions instead direct access.part2 Added accessor for widget allocation (available since GTK+ 2.17.7) and flags (available since 2.17.5) With this patch, gnome-bluetooth compiles with GSEAL_ENABLE without problems
Could you please remove the ifdef on the GTK+ version, and update the GTK+ requirements in configure.in? Then it looks fine to commit to master after the branching for the 2.28 release.
Created attachment 141066 [details] [review] Use accessor functions instead direct access.part2v2 Removed GTK_CHECKs and updates GTK+ requirements (2.17.7) in configure.ac as you requested
The gconf-bridge changes need to be done upstream, and the changes to bling-spinner removed (as we'll be using GtkSpinner instead).
Created attachment 150116 [details] [review] Use accessor functions instead direct access.part2v3 Also, gconf-bridge changed upstream: http://git.gnome.org/browse/libgconf-bridge/commit/?id=102b8d5cd8ccd210f7186fdb365fdd1cfaf15d73 So when the gconf-bridge upstream changes get imported into gnome-bluetooth we can close this bug
Created attachment 150636 [details] [review] Update from libgconf-bridge git module Update copy/paste code from original module.
Attachment 150636 [details] pushed as b8ec8a2 - Update from libgconf-bridge git module
Properly fixed with the new custom GtkAssistant page type.