After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587418 - Use accessor functions instead direct access (use GSEAL GnomeGoal)
Use accessor functions instead direct access (use GSEAL GnomeGoal)
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
2.27.x
Other Linux
: Normal trivial
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on: 576498 585211
Blocks: 585391
 
 
Reported: 2009-06-30 12:05 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-10-31 16:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use accessor functions instead direct access (4.11 KB, patch)
2009-06-30 12:10 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Use accessor functions instead direct access.part2 (5.57 KB, patch)
2009-08-18 12:34 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Use accessor functions instead direct access.part2v2 (5.77 KB, patch)
2009-08-18 12:48 UTC, Javier Jardón (IRC: jjardon)
needs-work Details | Review
Use accessor functions instead direct access.part2v3 (3.85 KB, patch)
2009-12-20 19:41 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Update from libgconf-bridge git module (10.30 KB, patch)
2010-01-01 12:52 UTC, Bastien Nocera
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-06-30 12:05:37 UTC
See http://live.gnome.org/GnomeGoals/UseGseal for more details
Comment 1 Bastien Nocera 2009-06-30 12:10:21 UTC
What functions?
Comment 2 Javier Jardón (IRC: jjardon) 2009-06-30 12:10:48 UTC
Created attachment 137613 [details] [review]
Use accessor functions instead direct access

It's a partial patch because there is not accesor functions for GtkObject flags (
See bug #562937 ) and there is not accesor functions for GtkWidget allocations
( See bug #585211 )
Comment 3 André Klapper 2009-06-30 12:15:19 UTC
Reopening.
Comment 4 Bastien Nocera 2009-06-30 12:15:52 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 5 André Klapper 2009-06-30 12:49:05 UTC
The bug is not fixed as it depends on bug 585391 to get fixed. :-)
Comment 6 Javier Jardón (IRC: jjardon) 2009-08-18 12:34:19 UTC
Created attachment 141059 [details] [review]
Use accessor functions instead direct access.part2

Added accessor for widget allocation (available since GTK+ 2.17.7)
and flags (available since 2.17.5)

With this patch, gnome-bluetooth compiles with GSEAL_ENABLE without problems
Comment 7 Bastien Nocera 2009-08-18 12:38:58 UTC
Could you please remove the ifdef on the GTK+ version, and update the GTK+ requirements in configure.in?

Then it looks fine to commit to master after the branching for the 2.28 release.
Comment 8 Javier Jardón (IRC: jjardon) 2009-08-18 12:48:10 UTC
Created attachment 141066 [details] [review]
Use accessor functions instead direct access.part2v2

Removed GTK_CHECKs and updates GTK+ requirements (2.17.7) in configure.ac as you requested
Comment 9 Bastien Nocera 2009-10-27 17:09:05 UTC
The gconf-bridge changes need to be done upstream, and the changes to bling-spinner removed (as we'll be using GtkSpinner instead).
Comment 10 Javier Jardón (IRC: jjardon) 2009-12-20 19:41:42 UTC
Created attachment 150116 [details] [review]
Use accessor functions instead direct access.part2v3

Also, gconf-bridge changed upstream: http://git.gnome.org/browse/libgconf-bridge/commit/?id=102b8d5cd8ccd210f7186fdb365fdd1cfaf15d73

So when the gconf-bridge upstream changes get imported into gnome-bluetooth we can close this bug
Comment 11 Bastien Nocera 2010-01-01 12:52:41 UTC
Created attachment 150636 [details] [review]
Update from libgconf-bridge git module

Update copy/paste code from original module.
Comment 12 Bastien Nocera 2010-01-01 12:53:39 UTC
Attachment 150636 [details] pushed as b8ec8a2 - Update from libgconf-bridge git module
Comment 13 Bastien Nocera 2010-10-31 16:19:51 UTC
Properly fixed with the new custom GtkAssistant page type.