After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587095 - codec rendering settings are constantly reset
codec rendering settings are constantly reset
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal major
: 0.14
Assigned To: Pitivi maintainers
Pitivi maintainers
: 644832 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-06-26 22:31 UTC by Jean-François Fortin Tam
Modified: 2011-05-23 19:37 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2009-06-26 22:31:19 UTC
If you set something in a codec's setting (for example, x264enc) and click OK, and go back in that dialog, the settings will all have been reset.

Users have no way whatsoever to "trust" this. If they notice this weird behavior, then they don't even know if pitivi..
- resets the settings everytime you re-open the settings dialog
- simply ignores anything you put in there, when clicking the OK button (aka "the settings were not there to begin with")
Comment 1 Edward Hervey 2009-06-27 07:37:02 UTC
I'm pretty sure I had fixed this for 0.13.1 :(
Comment 2 Edward Hervey 2009-07-19 17:38:47 UTC
Works fine here. Can you confirm ?
Comment 3 Jean-François Fortin Tam 2009-07-25 12:46:49 UTC
Yes, it works now, even with saving and loading the project :)
Comment 4 Jean-François Fortin Tam 2009-07-25 12:55:05 UTC
Also tested with rendering.
Comment 5 Jean-François Fortin Tam 2009-07-27 01:51:03 UTC
Ok, actually, I just figured out that it resets to the project settings. So if you didn't go in the project settings dialog to set the codecs, resolution, etc., each time you set something in the render dialog, close that dialog and open it again, it will have been reset to the default project settings.
Comment 6 Edward Hervey 2009-07-27 09:49:42 UTC
Jeff, Can you give the exact names of the dialogs you open/close (and how you closed them, pressing on which button,...) for that use-case ? Or better yet a screencast, I'm just confused by this bug.
Comment 7 Jean-François Fortin Tam 2009-07-29 23:17:06 UTC
Got the screencast. http://jeff.ecchi.ca/public/bug-pitivi-587095.ogv

Two things:
- the settings of the codec are the ones being reset now
- previously, the resolution and codecs used and whatnot were also being reset. They are now kept, BUT, they override the project settings (as you can see at 35 seconds in the screencast: previously 720p, the project settings are suddenly changed to 480p after setting that in the render settings). Not entirely sure this is what we want (otherwise, why make a render dialog separate from the project settings?).

Basically, if we are to use a render dialog that is separate from the project settings and indeed acts as an "override", well the settings of the render dialog must be remembered "only for the duration of this editing session" and not overwrite the global project settings.

Does that make sense?
Comment 8 Jean-François Fortin Tam 2010-12-11 17:34:41 UTC
I guess we're back to square one: AFAICT, the new rendering ui doesn't save rendering settings into the project file.
Comment 9 Jean-François Fortin Tam 2011-03-18 15:40:47 UTC
*** Bug 644832 has been marked as a duplicate of this bug. ***
Comment 10 Alex Băluț 2011-04-21 07:46:36 UTC
The problem with the new render dialog is that in EncodingDialog._displaySettings(), self.settings.vencoder is never passed to self.video_encoder_combo. See the empty "# Encoder/Muxer settings" block.

I'm working on a fix.
Comment 11 Thibault Saunier 2011-05-22 23:04:22 UTC
commit eb564e3b6e63119d722f55e4bc8771dd9545c2b2
Author: Alex Băluț <alexandru.balut@gmail.com>
Date:   Sat May 7 14:14:23 2011 +0200

    Fixed EncodingDialog to display the saved audio and video encoders when the dialog is opened.
    Fixes bug 587095.
Comment 12 Jean-François Fortin Tam 2011-05-23 19:37:43 UTC
See also bug 647023.