After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586806 - Fix iconv cflags/libs in configure.ac
Fix iconv cflags/libs in configure.ac
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.28.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
evolution[cleanup]
: 588267 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-06-24 03:03 UTC by H.Habighorst
Modified: 2013-09-13 01:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28

Attachments
Fixes iconv cflags/libs (645 bytes, patch)
2009-06-24 03:04 UTC, H.Habighorst 		reviewed Details | Review
Quote withval in ICONV check for proper results (377 bytes, patch)
2009-06-24 12:59 UTC, H.Habighorst 		committed Details | Review

Description H.Habighorst 2009-06-24 03:03:35 UTC 
When compiling, there is on my system a warning that /include cannot be found.

This was because ICONV_CFLAGS was always set to "-I$withval/include" - this was introduced in commit 3462659b0a40d099630be394094788746f470f44 I think.

The solution is dead simple : Before setting ICONV_CFLAGS / ICONV_LIBS, check that $withval is not empty.
Comment 1 H.Habighorst 2009-06-24 03:04:30 UTC 
Created attachment 137281 [details] [review]
Fixes iconv cflags/libs
Comment 2 Matthew Barnes 2009-06-24 12:03:13 UTC 
Oh good, I wondered where that was coming from.  But wouldn't it also work to just quote $withval in the directory test?  Then you don't need the -n test.

   if test -d "$withval"; then
Comment 3 H.Habighorst 2009-06-24 12:59:56 UTC 
Created attachment 137309 [details] [review]
Quote withval in ICONV check for proper results

New patch added. It's the simpler way :) Seems as if I thought a bit too complex.
Will add new patch to evolution-data-server
Comment 5 Matthew Barnes 2009-07-10 20:28:10 UTC 
*** Bug 588267 has been marked as a duplicate of this bug. ***