After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586767 - Use accessor functions instead direct access
Use accessor functions instead direct access
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
git master
Other Linux
: Normal trivial
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on: 585211
Blocks: 585391
 
 
Reported: 2009-06-23 16:11 UTC by Javier Jardón (IRC: jjardon)
Modified: 2009-12-08 17:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28

Attachments
Use accessor functions instead direct access (9.91 KB, patch)
2009-06-23 16:12 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Replace gtk_label_set_text() with gtk_message_dialog_set_markup() (1.33 KB, patch)
2009-08-29 18:00 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-06-23 16:11:16 UTC 
See http://live.gnome.org/GnomeGoals/UseGseal for more details
Comment 1 Javier Jardón (IRC: jjardon) 2009-06-23 16:12:37 UTC 
Created attachment 137263 [details] [review]
Use accessor functions instead direct access

Is a partial patch because there is not accesor functions for GtkObject flags (
See bug #562937 ) and there is not accesor functions for GtkWidget allocations
( See bug #548052 )
Comment 2 Lucas Rocha 2009-08-10 23:56:56 UTC 
Pushed your patch with a some coding style fixes. Keeping the bug report open as we haven't fixed all direct-access cases yet.
Comment 3 Javier Jardón (IRC: jjardon) 2009-08-29 18:00:00 UTC 
Created attachment 141995 [details] [review]
Replace gtk_label_set_text() with gtk_message_dialog_set_markup()

With this patch, gnome-session compiles with -DGSEAL_ENABLED without problems
Comment 4 Matthias Clasen 2009-10-14 03:48:12 UTC 
That patch looks fine to me.
Comment 5 Vincent Untz 2009-12-08 09:23:52 UTC 
Review of attachment 141995 [details] [review]:

Thanks, please commit with the small change!

::: gnome-session/gsm-logout-dialog.c
@@ +441,3 @@
         gtk_window_set_icon_name (GTK_WINDOW (logout_dialog), icon_name);
         gtk_window_set_position (GTK_WINDOW (logout_dialog), GTK_WIN_POS_CENTER_ALWAYS);
+        gtk_message_dialog_set_markup (GTK_MESSAGE_DIALOG (logout_dialog), primary_text);

Please add a comment to explain that we don't need to escape the text since there's no markup in the string.
Comment 6 Javier Jardón (IRC: jjardon) 2009-12-08 17:39:44 UTC 
Comment on attachment 141995 [details] [review]
Replace gtk_label_set_text() with gtk_message_dialog_set_markup()

commit c1e06e09f2580f9edd75f2d3609062d52c84b6f6

Committed with the comment.
Thank you!
Comment 7 Javier Jardón (IRC: jjardon) 2009-12-08 17:41:03 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.