After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586762 - Revise icon fallback logic for device icons on "-" tokens
Revise icon fallback logic for device icons on "-" tokens
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: Other
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-06-23 15:21 UTC by Martin Szulecki
Modified: 2018-02-10 03:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28



Description Martin Szulecki 2009-06-23 15:21:57 UTC
I need to set the icon for a GVFS backend mount to "multimedia-player-apple-ipod-touch" as defined by the fd icon spec in order to show the corresponding device icon in Nautilus.

Nautilus uses gtk_icon_theme_lookup_icon() with the GENERIC_FALLBACK option to allow fallbacks along tokens split by "-".

I have installed my "multimedia-player-apple-ipod-touch" icons to the hicolor "general" theme in the correct folders.

The call to gtk_icon_theme_lookup_icon(..."multimedia-player-apple-ipod-touch"...) with the GENERIC_FALLBACK flag always ends up showing the "multimedia-player" icon, despite having installed the correct device icons to the hicolor theme!

To make it funny, if you do not pass the GENERIC_FALLBACK flag the icon is found, since the code path jumps to also check the fallback icon theme for the icon down to the hicolor theme.

Note that the behavior so far is not really a bug but rather a feature.

However, it is not necessarily the expected behavior nor it's implications are helpful regarding efficient reuse of device specific icons.

The issue becomes even more prominent if you pick a scenario where the gnome-icon-theme has a lot of nice device specific icons and you have set a different theme on your desktop.

Then all icons would show up with generic icons despite there might be hundreds of nice device specific icons usable from gnome-icon-theme which acts as a "fallback theme" if icons are not found in the current theme.
Comment 1 Matthias Clasen 2018-02-10 03:23:56 UTC
We're moving to gitlab! As part of this move, we are closing bugs that haven't seen activity in more than 5 years. If this issue is still imporant to you and
still relevant with GTK+ 3.22 or master, please consider creating a gitlab issue
for it.