After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586678 - "Manage favorites" dialog don't display the Room column if showing all account
"Manage favorites" dialog don't display the Room column if showing all account
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Multi User Chat
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-22 19:47 UTC by Olivier Le Thanh Duong
Modified: 2009-11-26 10:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot when we display all account (16.10 KB, image/png)
2009-06-22 19:49 UTC, Olivier Le Thanh Duong 		  Details
Screenshot when we display only one account (19.69 KB, image/png)
2009-06-22 19:50 UTC, Olivier Le Thanh Duong 		  Details
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/room-column-586678 (1.75 KB, patch)
2009-11-25 17:51 UTC, Guillaume Desmottes 		reviewed Details | Review

Description Olivier Le Thanh Duong 2009-06-22 19:47:31 UTC 
In the "Manage favorites" dialog if we show the rooms in all accounts (the default) the Room column isn't displayed. If we switch to one particular account the column appear.
Comment 1 Olivier Le Thanh Duong 2009-06-22 19:49:27 UTC 
Created attachment 137201 [details]
Screenshot when we display all account
Comment 2 Olivier Le Thanh Duong 2009-06-22 19:50:23 UTC 
Created attachment 137202 [details]
Screenshot when we display only one account
Comment 3 Guillaume Desmottes 2009-11-25 17:39:40 UTC 
Bug still present in master.
Comment 4 Guillaume Desmottes 2009-11-25 17:51:20 UTC 
Created attachment 148455 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/room-column-586678

 src/empathy-chatrooms-window.c |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)
Comment 5 Cosimo Cecchi 2009-11-25 20:34:10 UTC 
Review of attachment 148455 [details] [review]:

The code looks fine; probably the accounts which do not support rooms should be removed from the combobox as well? (probably another bug)
Comment 6 Guillaume Desmottes 2009-11-26 10:37:49 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

I opened bug #603027 about the other issue.