GNOME Bugzilla – Bug 586580
Orca repeats the coordinates of Calc cells
Last modified: 2009-11-09 21:35:22 UTC
Steps to reproduce: 1. Launch Calc 2. Navigate amongst cells Expected results: Orca would speak the coordinates one time. Actual results: Orca speaks the coordinates one time per digit in the coordinates. From debug.out: generateSpeech for {'formatType': 'unfocused', 'role': ROLE_TABLE_CELL, 'mode': 'speech', 'recursing': True} using 'newAncestors + newRowHeader + newColumnHeader + newRadioButtonGroup + endOfTableIndicator + tableCellRow + newNodeLevel + (tutorial and (pause + tutorial) or [])' newAncestors=[] newRowHeader=[] newColumnHeader=[] newRadioButtonGroup=[] endOfTableIndicator=[] tableCellRow=['', 'A1009', 'A1009', 'A1009', 'A1009'] newNodeLevel=[] GENERATOR: _getTutorialForTableCell obj = Cell A1009 role = table cell alreadyFocused = False utterances: GENERATOR: _getTutorialForTableCellRow obj = Cell A1009 role = table cell alreadyFocused = False utterances: GENERATOR: getTutorial obj = Cell A1009 role = table cell alreadyFocused = False utterances: () tutorial=[''] pause=[<orca.speech_generator.Pause instance at 0x85bf46c>] generateSpeech generated '['', 'A1009', 'A1009', 'A1009', 'A1009', <orca.speech_generator.Pause instance at 0x85bf46c>, '']' SPEECH OUTPUT: 'A1009 A1009 A1009 A1009.'
Created attachment 137143 [details] [review] patch With this patch: ~~~~~~~~~~~ generateSpeech for {'formatType': 'unfocused', 'role': ROLE_TABLE_CELL, 'mode': 'speech', 'recursing': True} using 'newAncestors + newRowHeader + newColumnHeader + newRadioButtonGroup + endOfTableIndicator + tableCellRow + newNodeLevel + (tutorial and (pause + tutorial) or [])' newAncestors=[] newRowHeader=[] newColumnHeader=[] newRadioButtonGroup=[] endOfTableIndicator=[] tableCellRow=['', 'A1009'] newNodeLevel=[] GENERATOR: _getTutorialForTableCell obj = Cell A1009 role = table cell alreadyFocused = False utterances: GENERATOR: _getTutorialForTableCellRow obj = Cell A1009 role = table cell alreadyFocused = False utterances: GENERATOR: getTutorial obj = Cell A1009 role = table cell alreadyFocused = False utterances: () tutorial=[''] pause=[<orca.speech_generator.Pause instance at 0x85bf46c>] generateSpeech generated '['', 'A1009', <orca.speech_generator.Pause instance at 0x85bf46c>, '']' SPEECH OUTPUT: 'A1009.' ~~~~~~~~~~~ Will, please review. Thanks! (And this only seems to occur post refactor.)
Yep - looks like the 'break' accomplishes the equivalent of the 'return utterances' line in gnome-2-26: http://git.gnome.org/cgit/orca/tree/src/orca/scripts/apps/soffice/speech_generator.py?h=gnome-2-26#n289 Thanks for finding this.
Thanks Will. Committed to master.