Bug 586545 - Drop GeditMessageArea in favor of the new GtkInfoBar
Drop GeditMessageArea in favor of the new GtkInfoBar
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
2.27.x
Other Linux
: Normal normal
: 2.28
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-06-21 16:40 UTC by Filippo Argiolas
Modified: 2009-07-04 07:53 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: 2.27/2.28

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Filippo Argiolas 2009-06-21 16:40:46 UTC 
Now that the widget landed in in gtk+ there is no reason to keep using and maintaining a custom one. GEdit itself already did the switch (they build with infobar if gtk+ >= 2.17.2 but will probably completely drop message area soon).
IMHO we can just drop it since we're already closely following gtk+ releases and it will be in gtk+ 2.18 in time for 2.28.
Comment 1 Jaap A. Haitsma 2009-06-21 17:22:56 UTC 
Agree. I suggest just bumping gtk+ >= 2.17.2
You can also rip out 
cheese_about_dialog_handle_url and
cheese_about_dialog_handle_email
because these links work by default in gtk 2.17.2 :-)
Comment 2 Filippo Argiolas 2009-07-04 07:53:29 UTC 
commit 71ee16c5a19deec83286e15f674f666ded0cb78f
Author: Filippo Argiolas <filippo.argiolas@gmail.com>
Date:   Thu Jul 2 18:16:47 2009 +0200

    window: drop url and email handlers
    
    Drop url and email handlers used in the about dialog since gtk+ 2.17.2
    already provides that functionality built in.

commit c2473c4df9926dfd79fef8660b23c29f4ca2bd72
Author: Filippo Argiolas <filippo.argiolas@gmail.com>
Date:   Thu Jul 2 18:03:54 2009 +0200

    nocamera: drop GEditMessageArea in favor of GtkInfoBar
    
    Drop GEditMessageArea since it recently entered gtk+. Fixes bug #586545

commit 880b44b88e216df0e51ea9348dc49693fc8bfc63
Author: Filippo Argiolas <filippo.argiolas@gmail.com>
Date:   Thu Jul 2 18:03:31 2009 +0200

    build: bump gtk dependency to 2.17.
Note You need to log in before you can comment on or make changes to this bug.