Created attachment 137081 [details] [review]
use-distributor-logo.diff

Due to the fact I didn't find it, the icon is missing in the computer:/// but it's present in places dialog. Please help

The icon isn't used in computer: because computer: is a GVFS backend (gvfsd-computer). Nautilus really expects this to come from there and not shoehorned in here.

Furthermore, distributor-logo afaik isn't a widely accepted icon name, so it's likely that icon will be missing, resulting in the ugly not-found icon for everyone, so we'd need to specify fallbacks.

Thanks for the immediate answer. We can use themed icons with fallbacks, it's simple.
can you tell me if patching only gvfs would resolve also the places icon, or will we need also this patch?

Created attachment 137085 [details] [review]
GVFS-use-distributor-logo.diff

Created attachment 137086 [details] [review]
use

Created attachment 137087 [details] [review]
NAUTILUS-use-distributor-logo.diff

sorry, wrong name

it fallbacks first to "start-here" which is from the icon naming spec, and then to the original folder "driver-harddisk"

A. Walton, my work is finished. Do you accept those patches or should I make other changes?

-  file->display_name = g_strdup (_("Filesystem"));
+  file->display_name = g_strdup (_("File System"));

Please revert this. Also see bug 586573.

Woops sorry! this was a previous change I forgot :(

Created attachment 137141 [details] [review]
GVFS-use-distributor-logo.diff

Ready

Ping, no chance for 2.28?

The current patch uses only icons available in the present list of icons.
The drive will be displayed as a logo , which will not make it clear that the filesystem is a drive.
If the patch is applied , this would be a workaround and not a proper patch.

The ideal way would be to create a new icon name for the "Filesystem"
Either : drive-harddisk-root or drive-harddisk-dist

If it is absolutely essential to get this done in Ubuntu Karmic, it is easier to edit the gnome-dev-harddisk icon to have a logo than applying the current patch , which would affect all the distributions.

I'm rewriting the patches now, but we need the attention of the developers...

Another question to the developers is: why do I have to patch both nautilus and gvfs? don't you think that nautilus should use gvfs to get the filesystem icon?

Created attachment 143095 [details] [review]
GVFS_drive_hardisk_root_icon.patch

Created attachment 143096 [details] [review]
NAUTILUS_drive_hardisk_root_icon.patch

I have to test this

Created attachment 143097 [details] [review]
NAUTILUS_drive_hardisk_root_icon.patch

This one fixes a bug: missing icon in the placebar if the theme does not supply -root icon. That is because NautilusIconInfo didn't use fallbacks, so I added it.

tested works

I've requested a specific icon for File System in bug 620239. What we still seem to be lacking are clear arguments why this change is necessary. Any comments? I'm marking this bug as NEEDINFO.

*** Bug 561926 has been marked as a duplicate of this bug. ***

Nicolò, could you comment on the questions raised by Allan in comment #18?

I didn't understand the request. Why do you think it's not good to show the distribution icon in the filesystem?

I want a distribution icon on the file system to increase usability.

I have many disk drives on the computer with multiple partitions.
Then it would increase usability to have an distribution icon in order for the user to quickly be able to visually recognize which file system it is that have the operating system installed and distinguish it from other file systems.

It would also be nice to have a Windows logo icon on the disk drive on any file system with Windows installed.

Windows Vista and Windows 7 does this.

* http://i29.tinypic.com/35kmp87.jpg
* http://www.windows7update.com/images/Microsoft-Windows-7-Computer.jpg

Reopening as per the last comments.

Review of attachment 143095 [details] [review]:

This should be filed as a bug against GVfs, not nautilus.

Review of attachment 143097 [details] [review]:

::: nautilus-2.27.92.old/src/nautilus-places-sidebar.c
@@ +437,3 @@
 	NautilusIconInfo *info;
 	
+	icon = g_themed_icon_new_with_default_fallbacks (name);

Not sure why you need to change the default NautilusIconInfo lookup function.

My preference for this is to use a distributor emblem composed over the file system icon, like Windows does.
It would be nice to have the distributor icon as a standard icon name probably.

I think this bug should be reassigned to GVfs as per comment #25 as that is where these icons are hardcoded.

Currently Nautilus does its own calls to get the Icon (This can be seen by the patches). Changes currenlty need to be made to both Nautilus and GVfs and Nautilus also has the icons hardcoded. 

>Not sure why you need to change the default NautilusIconInfo lookup function.

As you can see be reading the comment trail, the call needs to be changes so that if the icon does not exist, then it falls back to the default filesystem icon rather than an ugly missing icon.
See the GTK doc for more details: http://developer.gnome.org/gio/2.28/GThemedIcon.html#g-themed-icon-new-with-default-fallbacks

Finally a new icon name of drive-harddisk-system has been created as seen by the depended bug https://bugzilla.gnome.org/show_bug.cgi?id=620239 and the case for this Icon change seems to now be generally accepted.

If I update the patch to the latest code, will the Nautilus developers apply it?

Ok, I have filed the bug report for the change needed for gvfs.
https://bugzilla.gnome.org/show_bug.cgi?id=655692

Also I now get the comment questioning why NautilusIcoInfo needed to be change.

The patch submitted commented:
This one fixes a bug: missing icon in the placebar if the theme does not supply
-root icon. That is because NautilusIconInfo didn't use fallbacks, so I added
it.

This should probably looked at to see if there is a better way to change.

I was about to post an updated patch for this bug, when I realised it is fixed in 3.1.4.

is set to NAUTILUS_ICON_FILESYSTEM = "drive-harddisk-system"

:)

Can someone please close this bug

Closing, thanks.