GNOME Bugzilla – Bug 586409
port cdda backend to libgudev
Last modified: 2009-07-08 17:27:33 UTC
With hal being deprecated, it would be nice to be able to build gvfs without hal. cdda is one of the modules which need to be ported over to gudev.
(FYI, see https://wiki.ubuntu.com/Halsectomy for current status)
I'm going to give this a try, I want to learn gudev anyway.
Created attachment 137066 [details] [review]
Here it is. That was a nice little exercise to learn gudev. I tested it with an audio CD in my USB CD drive, and ensured that gvfsd-cdda auto-unmounts on both "tray open" (change event to "no media") and "rip out USB cable" (remove event on sr0). "gvfs-info -f cdda://sr0/" shows the correct size with gudev. Backend builds and works with just gudev, just libhal, both (then gudev is used), and does not build if neither is available.
Oops, I just noticed that in the very last hunk I forgot a
Patch looks fine to me (with the correction you pointed out)
Will review this (and other hal->gudev patches) soon, haven't forgot, will get to it this week.
Pushed the patch with that fix. Thanks.