After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586379 - Support for adium Header.html and header/footer macros
Support for adium Header.html and header/footer macros
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Chat themes
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-19 13:06 UTC by Xavier Claessens
Modified: 2018-05-22 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Partial fix (1.69 KB, patch)
2009-06-19 14:01 UTC, Patryk Zawadzki 		reviewed Details | Review
Updated patch (1.73 KB, patch)
2009-06-19 14:19 UTC, Patryk Zawadzki 		committed Details | Review

Description Xavier Claessens 2009-06-19 13:06:57 UTC 
Atm we do not use the header and footer html files if provided by the theme.
Comment 1 Patryk Zawadzki 2009-06-19 14:01:54 UTC 
Created attachment 137006 [details] [review]
Partial fix

First part of the fix is to implement naive footer support. Most of the themes
only sue Footer.html to load custom JS files so until we add header support
this should be enough to make most themes happy.
Comment 2 Xavier Claessens 2009-06-19 14:07:05 UTC 
I think you can save memory by not keeping footer_html in priv struct. You only need it for initial loading ;)
Comment 3 Patryk Zawadzki 2009-06-19 14:19:44 UTC 
Created attachment 137008 [details] [review]
Updated patch

Updated according to review
Comment 4 Xavier Claessens 2009-06-19 14:21:12 UTC 
Seems good :)
Comment 5 Guillaume Desmottes 2009-06-22 12:01:01 UTC 
Closing the bug as the patch has been merged.
Comment 6 Patryk Zawadzki 2009-06-22 12:05:51 UTC 
Uh, we only have naive support for footers, no header support and no macro support. That's hardly "fixed" :)
Comment 7 GNOME Infrastructure Team 2018-05-22 13:32:11 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/82.