GNOME Bugzilla – Bug 586023
"revert to saved version" feature
Last modified: 2010-06-19 15:11:28 UTC
A somewhat interesting feature I discovered in iMovie: there is a "File > Revert to saved" menu item which allows to "go back to the last saved version of [the] project, canceling any unsaved changes".
Create a branch with "Revert to saved" option http://github.com/m3tr0/revert-to-saved
With my superficial testing (with a simple scenario), it seems to work. I can't comment about the implementation/code, but here are some suggestions for the UI: - The menu item should be greyed out when it cannot be used (ie: when the project has unsaved changes) - In the dialog, the sentence in the middle should end with a point ("All unsaved changes will be lost.") - Do not use Yes/No dialog buttons*, use imperative verbs instead. The "No" button should be "Cancel" and the "Yes" button should be "Revert". *: http://library.gnome.org/devel/hig-book/stable/controls-buttons.html.en
Once the corrections suggested by Jeff are done, I'll be able to merge this. Good work
New version with Jean-François Fortin Tam suggestions: -revert is enable when needed -add missing . in the sentence -change buttons yes_no with revert_cancel You can find the branch at: http://github.com/m3tr0/revert-to-saved
Merged and pushed. Thanks a lot :) commit d4e35103aab2ea4fb750dc6552eef32997856414 Author: Pier Carteri <pier.carteri@gmail.com> Date: Fri Jun 18 23:27:06 2010 +0200 UI: Revert enable when needed. Change button on message dialog Fixes #586023 commit daaffdd684a4e91ba27f7227a1f109a9359ee508 Author: Pier Carteri <pier.carteri@gmail.com> Date: Sun Jun 6 11:01:28 2010 +0200 ui: revert-to-saved small cleanup commit 5a9361c023524ce24a5bade6be16b90e35f9e9f4 Author: Pier Carteri <pier.carteri@gmail.com> Date: Sun Jun 6 10:56:20 2010 +0200 project: Add revert to saved option (Bug 586023)
This is a HIG-compliance nitpick really, but the Revert button should be on the right and the Cancel button on the left, because Revert is the "affirmative" action here*. However, keep the Cancel button as the one with the default focus, because it's the "safe" action. Thanks for the great work! *: http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en#alert-button-order
oh, sorry :-( fix the order of buttons. The fix is in http://github.com/m3tr0/revert-to-saved Thank you all for feedback!
I'm marking this as RESOLVED FIXED. If there are new issues, please open a new bug. commit 9e706c9009f5c863211b56d50619fc9b72922834 Author: Pier Carteri <pier.carteri@gmail.com> Date: Sat Jun 19 16:30:11 2010 +0200 UI: change order of revert and cancel buttons