GNOME Bugzilla – Bug 585967
[Side pane] Option to recursively expand entries in the index tree
Last modified: 2016-11-25 08:05:31 UTC
When viewing documents that supply table of contents data the index part of the side pane can use, it is sometimes useful to expand that tree structure to get an overview of the chapters and sections of the document without having to browse back to the table of contents in the actual document. Currently, clicking on an entry expands it, and lists its sub-entries (if any). These sub-entries start of closed, so if you want to see all sub-entries (and their sub-entries, etc.) for a specific node in the tree, you have to click all the entries one by one to expand them. I would like to suggest adding an option to recursively expand all sub-entries. This might be implemented by adding an option to the context menu, and additionally, perhaps by having a CTRL + click on an entry do the same. Other information:
I agree with this. Having to click on all nodes just to expand all sub-entries can be quite a hassle when working with large documents. A shortcut like the one proposed in the OP would greatly enhance the user experience in this respect.
Created attachment 258208 [details] [review] Ctrl+Click on an entry to recursively expand.
Review of attachment 258208 [details] [review]: Thanks for the patch, but I think we should expand all entries recursively when clicking on the expander, not the row itself. You should also configure your git to use a valid author and email, see https://wiki.gnome.org/Git/Developers#Setting_up_Git ::: shell/ev-sidebar-links.c @@ +364,3 @@ + if (event->button == GDK_BUTTON_PRIMARY && + event->state == GDK_CONTROL_MASK) { This doesn't work, you should use & instead of == with the mask. The indentation is not correct. @@ +365,3 @@ + if (event->button == GDK_BUTTON_PRIMARY && + event->state == GDK_CONTROL_MASK) { + if (gtk_tree_view_get_path_at_pos (GTK_TREE_VIEW (treeview), Indentation is not correct here either, we use 8 spaces. @@ +371,3 @@ + NULL, NULL, NULL)) { + gtk_tree_view_expand_row (GTK_TREE_VIEW (treeview), + path, TRUE); You should free the path. @@ +372,3 @@ + gtk_tree_view_expand_row (GTK_TREE_VIEW (treeview), + path, TRUE); + If we ended up here, it's because button is not 3, so you can return here.
Created attachment 258793 [details] [review] Ctrl+Click on an entry to recursively expand.
*** Bug 638625 has been marked as a duplicate of this bug. ***
Review of attachment 258793 [details] [review]: This patch looks correct to me (besides a trailing space). Ok to commit it?
The patch still expands the tree when clicking on the row, not when clicking the expander. I'm not sure it's possible to do that with the cell renderer, though.
(In reply to comment #7) > The patch still expands the tree when clicking on the row, not when clicking > the expander. I'm not sure it's possible to do that with the cell renderer, > though. I don't think so. I filed a bug in gtk+ for adding such behaviour: https://bugzilla.gnome.org/show_bug.cgi?id=729531 This does not mean that this is going to be fixed. On seconds thoughts, clicking on the row is not that bad, considering it will be ctrl+click and not a regular click.
If you select a row and type Shift + <right arrow>, it recursively expands all entries beneath it. This is built-in GtkTreeView behavior. I think this is good enough - yes? If so, this is just a documentation issue.
Yes indeed! It seems that since I reported this issue seven years ago GtkTreeView introduced this useful behaviour. Thanks for pointing it out, I didn't know it could do that.