After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585870 - Gecko's clumpUtterances method probably can be removed
Gecko's clumpUtterances method probably can be removed
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
unspecified
Other All
: Normal normal
: 2.28.0
Assigned To: Willie Walker
Orca Maintainers
: 586078 (view as bug list)
Depends on:
Blocks: 404403
 
 
Reported: 2009-06-15 15:15 UTC by Willie Walker
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to avoid issues with clumpUtterances (4.03 KB, patch)
2009-06-17 13:31 UTC, Willie Walker
committed Details | Review

Description Willie Walker 2009-06-15 15:15:40 UTC
With the new speech generator refactor, the speech.py:speak method does clumping of utterances for us.  So, Gecko's clumpUtterances method probably can be removed.  It probably is also buggy now since it assumes utterances are composed of strings.
Comment 1 Willie Walker 2009-06-15 15:16:28 UTC
As an experiment, I put a "return utterances" line at the beginning of clumpUtterances and things *seemed* to work OK, though I didn't run the regression tests.

Comment 2 Willie Walker 2009-06-16 21:37:29 UTC
(In reply to comment #1)
> As an experiment, I put a "return utterances" line at the beginning of
> clumpUtterances and things *seemed* to work OK, though I didn't run the
> regression tests.

Can you spell "NOPE!"?  :-)

Needs some more investigation.  Here's an example regression:

Test 5 of 13 FAILED: /export/home/orca/orca/test/keystrokes/firefox/bug_512303.p
y:Line Down
DIFFERENCES FOUND:
  BRAILLE LINE:  '4 5 6'
       VISIBLE:  '4 5 6', cursor=1
- SPEECH OUTPUT: '4 5 6'
?                  ----

+ SPEECH OUTPUT: '4'
+ SPEECH OUTPUT: '5'
+ SPEECH OUTPUT: '6'
Comment 3 Willie Walker 2009-06-17 12:56:49 UTC
*** Bug 586078 has been marked as a duplicate of this bug. ***
Comment 4 Willie Walker 2009-06-17 12:57:45 UTC
See also http://bugzilla.gnome.org/show_bug.cgi?id=586078#c2 for how clumpUtterances is now buggy since it assumes utterances are composed of strings only.
Comment 5 Willie Walker 2009-06-17 13:31:35 UTC
Created attachment 136831 [details] [review]
Patch to avoid issues with clumpUtterances

This patch hopefully avoids the issues with clumpUtterances for now until we decide what to do with it.
Comment 6 Hammer Attila 2009-06-17 14:01:44 UTC
This patch is perfect!
Orca+Tab and Orca+Shift+tab combinations work again, Orca speech correct the next or prewious form fields.

Attila
Comment 7 Willie Walker 2009-06-22 12:39:42 UTC
Thanks for testing, Attila!