After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585868 - [keyboard] Find the index of layout to activate after filter
[keyboard] Find the index of layout to activate after filter
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-15 15:08 UTC by Vincent Untz
Modified: 2009-12-05 02:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[keyboard] Find the index of layout to activate after filter (2.11 KB, patch)
2009-06-15 15:08 UTC, Vincent Untz 		needs-work Details | Review
Updated patch (2.16 KB, patch)
2009-12-04 17:52 UTC, Vincent Untz 		none Details | Review

Description Vincent Untz 2009-06-15 15:08:47 UTC 
A small bug was introduced with the latest patch by Sergey (my fault, I should have spotted it).

Since we now potentially filter some xkb layouts out of the configuration, we need to have the filter done beore we find the index of the layout to activate. Else, there's no guarantee the index will be valid.
Comment 1 Vincent Untz 2009-06-15 15:08:50 UTC 
Created attachment 136638 [details] [review]
[keyboard] Find the index of layout to activate after filter

Since we now potentially filter some xkb layouts out of the
configuration, we need to have the filter done beore we find the index
of the layout to activate. Else, there's no guarantee the index will be
valid.
Comment 2 Jens Granseuer 2009-11-20 18:00:47 UTC 
Sergey?
Comment 3 Jens Granseuer 2009-12-02 20:40:47 UTC 
Comment on attachment 136638 [details] [review]
[keyboard] Find the index of layout to activate after filter

Vincent, could you please update the patch to apply to trunk? Thanks.
Comment 4 Vincent Untz 2009-12-04 17:52:18 UTC 
Created attachment 149102 [details] [review]
Updated patch
Comment 5 Sergey V. Udaltsov 2009-12-05 02:40:17 UTC 
Vincent, you're right, that block should be moved. Committed, thanks a bunch!