After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585766 - Please avoid the use of & in location names
Please avoid the use of & in location names
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: locations
unspecified
Other Linux
: Normal normal
: 2.22.0
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-14 18:47 UTC by F Wolff
Modified: 2013-07-28 20:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
replaced & with the plain text (810 bytes, patch)
2013-07-28 13:35 UTC, Evgeny Bobkin 		committed Details | Review

Description F Wolff 2009-06-14 18:47:54 UTC 
I just saw that the POT file for libgweather.locations contains this line:
msgid "Australasia & Oceania"

While it isn't too much trouble to make sure to translate the XML entity correctly, I'm not sure that this is ideal. If somebody gets this wrong, what happens to the application?  Please let the translators deal with plain text, and escape it as necessary for whatever you are using it for.

Another trap is that, if the translator wanted to use an ampersand in a line where the English did not have it (like "Saint Pierre and Miquelon") they might not remember to escape the ampersand as &. Msgfmt won't complain about this, so let us rather make sure that the application deals correctly with the text.
Comment 1 F Wolff 2010-06-04 15:49:07 UTC 
Ping.
Comment 2 F Wolff 2011-03-07 08:30:42 UTC 
Ping.
Comment 3 F Wolff 2011-08-23 14:50:13 UTC 
Ping.
Comment 4 Evgeny Bobkin 2013-07-28 09:39:17 UTC 
hey, is it still valid?
Comment 5 Bastien Nocera 2013-07-28 13:21:23 UTC 
Yes.
Comment 6 Evgeny Bobkin 2013-07-28 13:29:17 UTC 
back on pc. '&' appears only once in the entire database libgweather/data/Locations.xml.in as "Australasia & Oceania"
Comment 7 Evgeny Bobkin 2013-07-28 13:35:42 UTC 
Created attachment 250299 [details] [review]
replaced & with the plain text
Comment 8 Giovanni Campagna 2013-07-28 19:46:04 UTC 
Review of attachment 250299 [details] [review]:

Lame fix (the right one would be to handle escaping in intltool or dgettext or somewhere else), but probably the easiest one.
Comment 9 Evgeny Bobkin 2013-07-28 20:08:10 UTC 
(In reply to comment #8)
> Review of attachment 250299 [details] [review]:
> 
> Lame fix (the right one would be to handle escaping in intltool or dgettext or
> somewhere else), but probably the easiest one.

lol, not lame, the point of it was to use plain text, it makes sense, now it is consistent with other strings