After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585706 - Change GDA_TYPE_ERROR with G_TYPE_ERROR
Product: libgda
Classification: Other
Component: Client library
Other All
: Normal normal
: ---
Assigned To: malerba
gnome-db Maintainers
Depends on:
Blocks: 585351
Reported: 2009-06-14 05:33 UTC by Daniel Espinosa
Modified: 2009-08-26 07:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description Daniel Espinosa 2009-06-14 05:33:29 UTC
Please describe the problem:
GDA_TYPE_ERROR is used on the library to get GError types refering to bug #300610, but as this bug mention the G_TYPE_ERROR exist for a long time now then Change GDA_TYPE_ERROR to G_TYPE_ERROR.

This change is important becouse GObject Introspection fails to compile becouse doesn't find a definition of GdaError when this type is just a wrapper of GError.

Steps to reproduce:

Actual results:

Expected results:

Does this happen every time?

Other information:
Comment 1 Daniel Espinosa 2009-06-14 06:43:57 UTC
GLib doesn't have a G_TYPE_ERROR and G_TYPE_SLIST definition.

This isn't an macro names bug its on the definition of the GType function, becouse it must use the "GError" and "GSList" type name in order to make the introspection compile.
Comment 2 Daniel Espinosa 2009-06-14 07:27:57 UTC
This bug is fixed with the patch #136538 upload with the bug #585351
Comment 3 malerba 2009-06-15 15:03:24 UTC
It's not possible to rename GDA_TYPE_ERROR to G_TYPE_ERROR because this would conflict with GLib's own naming space (same for GDA_TYPE_SLIST). I'm sorry you'll have to find another way for the introspection.

Anyway, these defines are not usefull for the user (and _can't_ be used because they refer to symbols which are not exported) as they exist only for signal definitions, so maybe the solution is to avoid adding them to the introspection.
Comment 4 Daniel Espinosa 2009-06-15 18:26:44 UTC
Anjuta defines G_TYPE_ERROR and is documented at:

I'll rename back to GDA_TYPE_ERROR and will verify that introspection generates the files correctly; in order to make introspection to detect the correct type the patch will use "GError" instead "GdaError" and "GSList" instead "GdaSList".

See it at bug #585351. And the patch will be there too.
Comment 5 Daniel Espinosa 2009-06-15 19:11:47 UTC
The patch #136657, in the bug #585351, have the fix for your comment Vivien. And compilation of Introspection works.
Comment 6 malerba 2009-08-26 07:22:15 UTC
I'm closing this bug since it won't be changed, and we now have only the bug #585351 which is about intrispection.