After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585644 - Difference with mnemonic speech pitch
Difference with mnemonic speech pitch
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
unspecified
Other opensolaris
: Normal normal
: 2.28.0
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-13 13:08 UTC by Willie Walker
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This is a full debug.out, I hope determining why difference the mnemonic pitch. (87.97 KB, text/plain)
2009-06-13 13:33 UTC, Hammer Attila
  Details
Patch to put a pause in the suffix (611 bytes, patch)
2009-06-13 14:11 UTC, Willie Walker
none Details | Review
Patch to allow line breaks to be added to speech. (2.20 KB, patch)
2009-06-14 00:25 UTC, Willie Walker
none Details | Review
Patch that was committed (14.83 KB, patch)
2009-06-14 12:37 UTC, Willie Walker
committed Details | Review

Description Willie Walker 2009-06-13 13:08:46 UTC
In bug #585417, Attila raised an issue regarding a "difference with mnemonic speech pitch" between the Orca 2.26.x version and the Orca 2.27.x development version.  This bug will be used to discussed that difference.
Comment 1 Hammer Attila 2009-06-13 13:33:14 UTC
Created attachment 136500 [details]
This is a full debug.out, I hope determining why difference the mnemonic pitch.

I hope this debug.out determining why different the mnemonic pitch with 2.26 and 2.27.2 Orca version.
Comment 2 Willie Walker 2009-06-13 13:38:11 UTC
In looking at the debug output (thanks) and listening to the audio files attached to bug #585417, I don't see anything that would indicate a pitch change would occur and I cannot hear a pitch difference.  The thing I was listening for was "Alt p".

Which specific word or character should I be listening for to hear the change in pitch?  Is it the "p"?
Comment 3 Hammer Attila 2009-06-13 13:45:16 UTC
When I writing following text, press enter and up arrow:
alt p.
This is equals the problematic difference.
Alt p
Is right.
Please try navigate the following line with down arrow:
Preferences button. Alt p.
This is the wrong pitch,
Preferences button. Alt p
This is right, equals the 2.26.2 Version speech.
You see dots after the mnemonic informations with debug.out file? Possible only this is the problem?

Attila

 this editbox and press enter, press up arrow,
Comment 4 Hammer Attila 2009-06-13 13:49:22 UTC
And yes! Have dots with end of mnemonics with my debug.out file.
Possible keep pauses with mnemonics (not drop last committed pause patch), but remove dots with end of mnemonics? I think we found the problem.

Attila
Comment 5 Willie Walker 2009-06-13 14:11:50 UTC
Created attachment 136501 [details] [review]
Patch to put a pause in the suffix

(In reply to comment #4)
> And yes! Have dots with end of mnemonics with my debug.out file.
> Possible keep pauses with mnemonics (not drop last committed pause patch), but
> remove dots with end of mnemonics? I think we found the problem.

I hear a very subtle difference with eSpeak.  Try this patch - it adds a pause to the suffix for the spoken output.  This will result in a "." being added to the end of the complete utterance.  If it works, I'll work up a better patch.
Comment 6 Hammer Attila 2009-06-13 15:19:24 UTC
This patch unfortunately not good. Not solve the pitch problem.
When I try repeat the whole text with where am I for example, I hear following:
"Preferences button. Alt p. To activate, press space dot"
I look what hear when I choose hungarian language.
Comment 7 Hammer Attila 2009-06-13 15:32:58 UTC
I hear following text with hungarian language:
"Beállítások gomb. Alt B. Aktiválásához nyomja meg a szóköz billentyűt pont"
This is not good.
So, add "." with end of complete utterance does'nt need.
What happen when we remove only the "." after the mnemonics and the "." character with end of complete utterance?

I look my debug.out, what resulted the new patch, the three speech output line is:
SPEECH OUTPUT: 'Preferences button.'
SPEECH OUTPUT: 'Alt p.'
SPEECH OUTPUT: 'To activate, press space..'
I think the right wish result was following speech output:
SPEECH OUTPUT: 'Preferences button.'
SPEECH OUTPUT: 'Alt p'
SPEECH OUTPUT: 'To activate, press space.'

Attila
Comment 8 Willie Walker 2009-06-14 00:06:15 UTC
(In reply to comment #6)
> This patch unfortunately not good. Not solve the pitch problem.
> When I try repeat the whole text with where am I for example, I hear following:
> "Preferences button. Alt p. To activate, press space dot"
> I look what hear when I choose hungarian language.

Aha -  the problem is that all the tutorial strings have a "." at the end of them.  So with the patch, if you have tutorials enabled, you'll end up with ".." at the end of the string -- one "." for the tutorial and a second "." for the pause.

(In reply to comment #7)
...
> SPEECH OUTPUT: 'To activate, press space..'

Here's the confirmation of the "..".

> I think the right wish result was following speech output:
> SPEECH OUTPUT: 'Preferences button.'
> SPEECH OUTPUT: 'Alt p'
> SPEECH OUTPUT: 'To activate, press space.'

We can get you this (i.e., removing the ..):

SPEECH OUTPUT: 'Preferences button.'
SPEECH OUTPUT: 'Alt p.'
SPEECH OUTPUT: 'To activate, press space.'

With more work, I can probably get you what you're looking for.  Please tell me, however, is the subtle pitch change a minor issue, or is this is something that you view as a drastic problem?
Comment 9 Willie Walker 2009-06-14 00:25:43 UTC
Created attachment 136529 [details] [review]
Patch to allow line breaks to be added to speech.

(In reply to comment #8)
> > I think the right wish result was following speech output:
> > SPEECH OUTPUT: 'Preferences button.'
> > SPEECH OUTPUT: 'Alt p'
> > SPEECH OUTPUT: 'To activate, press space.'

This patch gives you this.  Please test.
Comment 10 Hammer Attila 2009-06-14 06:09:57 UTC
The last patch is very perfect.
The pitch problem is solwed, I think this bug is fixed.
Thank you your hard work!

Attila
Comment 11 Willie Walker 2009-06-14 12:37:43 UTC
Created attachment 136552 [details] [review]
Patch that was committed

Thanks for testing, Attila.  Here's the final patch that was committed, and it includes changes to the gtk-demo regression tests.  Something is up with the soffice tests (they are failing all over the place).  From what I can determine, however, those failures are not related to this change.  I'll be looking at those separately today.