Bug 585596 - port to PolicyKit 1.0
port to PolicyKit 1.0
Status: RESOLVED FIXED
Product: gconf-editor
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gconf Editor Maintainers
Gconf Editor Maintainers
:
Depends on: 585303
Blocks:
  Show dependency tree
 
Reported: 2009-06-12 18:45 UTC by Matthias Clasen
Modified: 2009-08-24 00:02 UTC (History)
3 users (show)

See Also:
GNOME target: 2.28.x
GNOME version: ---

Attachments
patch (16.86 KB, patch)
2009-06-12 18:45 UTC, Matthias Clasen 		none Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Matthias Clasen 2009-06-12 18:45:22 UTC 
Here is the patch we use in Fedora
Comment 1 Matthias Clasen 2009-06-12 18:45:51 UTC 
Created attachment 136466 [details] [review]
patch
Comment 2 Cosimo Cecchi 2009-06-13 23:02:16 UTC 
Thanks for the patch.
AFAICS this requires a patched GConf (bug 585303) to work, so let's mark this report as blocked by the GConf one.
Otherwise, the patch looks fine to me, apart for some duplicate code that could be factored out in a function (the snippet in gconf_pk_can_set() and gconf_pk_update_can_set_cache()) and some not-uniform indentation.
Comment 3 André Klapper 2009-08-13 17:37:30 UTC 
GConf dependency bug is fixed now.

Cosimo: Do we want to get this in as it is or do you insist on refactoring the code a bit? Because I assume that Matthias is quite short in time currently...
Comment 4 Cosimo Cecchi 2009-08-24 00:02:47 UTC 
Yeah, I pushed a modified version of this patch to master; I will release a new version containing this tomorrow.

commit 6d5c0ac4041eaac3bb76391523f167870e03164e
Author: Cosimo Cecchi <cosimoc@gnome.org>
Date:   Mon Aug 24 01:58:31 2009 +0200

    port to PolicyKit 1.0
    
    This also removes the need of depending on polkit-dbus, and needs a new
    GConf to work properly.
    Based on the patch by Matthias Clasen, fix bug #585596.
Note You need to log in before you can comment on or make changes to this bug.