GNOME Bugzilla – Bug 585383
Segfault in gdk_pixbuf__ico_image_save
Last modified: 2014-10-22 16:44:33 UTC
Trying to use the "Copy" functionality (with or without something selected) on some images make GIMP segfault. I will attach a GDB backtrace as well as an example image for this behaviour.
Created attachment 136303 [details] Example image
Created attachment 136304 [details] GDB backtrace
Looks like it crashes in GTK+. What are the exact step-by-step to consistently reproduce? What version of GTK+ are you using?
(In reply to comment #3) > Looks like it crashes in GTK+. What are the exact step-by-step to consistently > reproduce? 1. Open the provided file 2. Invoke GIMP’s copy function (via Ctrl-C, Edit menu, ...) > What version of GTK+ are you using? Running version 2.16.2 here.
Created attachment 136369 [details] GDB backtrace Revised version of the backtrace including GTK debugging symbols.
That fact that simply doing a copy causes a call into gdk-pixbuf indicates that you have some sort of clipboard manager running that requests the clipboard content without a good reason. Such clipboard manager behavior is totally broken and I strongly suggest you uninstall it and make sure that you have a clipboard manager that is implemented according to the Free Desktop clipboard manager specification http://www.freedesktop.org/wiki/ClipboardManager Anyway, this looks like a bug in the GTK+ ico save module. Reassigning accordingly.
(In reply to comment #6) > That fact that simply doing a copy causes a call into gdk-pixbuf indicates that > you have some sort of clipboard manager running that requests the clipboard > content without a good reason. Such clipboard manager behavior is totally > broken and I strongly suggest you uninstall it and make sure that you have a > clipboard manager that is implemented according to the Free Desktop clipboard > manager specification http://www.freedesktop.org/wiki/ClipboardManager You were right. After killing gnome-clipboard-daemon no further crash occurred. > Anyway, this looks like a bug in the GTK+ ico save module. Reassigning > accordingly. Thanks for this and your hint above.
The problem seems to be that the pixbuf plugin assumes that the image dimensions are always a multiple of 8 and in this case doesn't allocate any memory (6/8=0) for the ICO's AND-bitmap.
Created attachment 136629 [details] [review] simple fix Simply allocate an extra byte by for the remaining pixels.
See also bug 561669.
*** Bug 561669 has been marked as a duplicate of this bug. ***