Created attachment 136184 [details] [review]
Use accessor functions instead direct access

Is a partial patch because there is not accesor functions for GtkObject flags ( See bug #562937 ) and there is not accesor functions for GtkWidget allocations ( See bug #548052 )

Patch looks fine but please correct indentation. You use spaces at some places where you should use tabs.

Feel free to commit this patch already after correcting these indentation issues.

Created attachment 137142 [details] [review]
Use accessor functions instead direct access v2

Can someone review this and commit if all is ok? (I don't have commit permissions)

indentation is still not that perfect ;) you could install uncrustify and then run our indent script, which you can find under tools/

Created attachment 137149 [details] [review]
Use accessor functions instead direct access v3

Third round ;). Hope all is correct now. (vim :set list command was very useful)

Looks fine please commit.

Leave this bug open such that the remaining issues will also be solved as soon as the dependent bugs are fixed

Can someone commit this? (As I said in comment #3 I don't have commit permissions)
Thank you.

committed, thanks a lot

Created attachment 139553 [details] [review]
Fixed allocation issues

Created attachment 142926 [details] [review]
Use accessor functions instead direct access.part2

GTK+ 2.17.10 is now the required version
I've used all the GTK+ 2.17.11 api available, still missing:
GTK_WIDGET_MAPPED ()

Created attachment 149303 [details] [review]
Use accessor functions instead direct access.part2.v2

Here a new updated patch against current master.

With this patch, cheese will compile with GSEAL_ENABLED without problems (so, will be ready for GTK+3 :))

Hello, could this get a review?

Review of attachment 149303 [details] [review]:

I'm sorry Javier, your patch completely slipped out of my radar :(
I must have skipped it thinking to get back to it later but completely forgot.

It doesn't apply to current master, probably because of my little refactoring of cheese-window code.
Would you please update it? I think it can safely go in for 2.30.1

Review of attachment 149303 [details] [review]:

I'm sorry Javier, your patch completely slipped out of my radar :(
I must have skipped it thinking to get back to it later but completely forgot.

It doesn't apply to current master, probably because of my little refactoring of cheese-window code.
Would you please update it? I think it can safely go in for 2.30.1

Created attachment 157406 [details] [review]
Use accessor functions instead direct access. Final patch

Hey Filippo!, no problem ;)

Here the final patch to fix this bug.

I'd recommend you to add 

CFLAGS+="-DGSEAL_ENABLE"

to you configure.ac, so this bug won't be reopended

Javier: 
+  int col, row;
Why is this not at the beginning of that function but in the middle?

Andre (and Javier), FYI, I didn't forget about this bug.
I'm just pretty busy but I plan to commit this and some other trivial patches waiting in bugzilla before monday (2.30.1 release).

The following fix has been pushed:
cb32585 Use accessor functions instead direct access. Final patch

Created attachment 159309 [details] [review]
Use accessor functions instead direct access. Final patch

Fixes