GNOME Bugzilla – Bug 585049
When I select paragraphs with Ctrl+Shift+Down key combination, Orca says incorrect information message.
Last modified: 2009-11-09 21:35:38 UTC
Please describe the problem: Dear Developers! When I press Ctrl+Shift+down key combination, paragraphs selected correctly forexample with Openoffice.org Writer, but Orca says the following incorrect message: "Line selected down from cursor" This message is not right, because Shift+Ctrl+Down key combination paragraph selection command. I suggest following message: "Paragraph selected from cursor" Or: "Paragraph selected." I don't known what message seeing with braille displays, because I have'nt got a braille display. I very sorry impossible fix this problem with 2.26 version, because if I known right this version is string freezed and impossible change the output messages. If I don't known right, please fix this problem with 2.26 and latest development version. Tomorrow afternoon I try make a patch with fix this problem. Attila Steps to reproduce: 1. Launch for example with Openoffice.org Writer and write a longest text (enough OO to wrap the line). 2. Jump beginning of the document and press Ctrl+Shift+Down key combination. You hear the incorrect message, but the paragraph was selected. 3. Actual results: Orca says the incorrect message. Expected results: Please orca says "Paragraph selected from cursor" or "Paragraph selected" message. Does this happen every time? Yes. Other information:
Created attachment 136336 [details] [review] This is a first revision, fixes all important messages with the paragraph situation. This is a first revision. Fixes all important message (line word replace with paragraph) when the user press Shift+Ctrl+Down or Shift+Ctrl+Up key combination. I tested with Openoffice.org 3.0, works very well. Anybody testing the patch with braille display? Will, if my patch is correct, possible commit with master branch? Attila
Thanks Attila! (In reply to comment #1) > This is a first revision. Fixes all important message (line word replace with > paragraph) when the user press Shift+Ctrl+Down or Shift+Ctrl+Up key > combination. I tested with Openoffice.org 3.0, works very well. Anybody testing > the patch with braille display? Since this patch is in default.py, it will have an effect on every application. So, please test with a variety of applications. Since the change you made is isolated to spoken text only, testing with braille should not be necessary. > Will, if my patch is correct, possible commit with master branch? Questions such as "please commit this patch" and "please fix this bug" are always implied. So, you don't need to ask these kinds of questions in every bug report. :-) Thanks again!
(In reply to comment #2) > Thanks Attila! > > (In reply to comment #1) > > This is a first revision. Fixes all important message (line word replace with > > paragraph) when the user press Shift+Ctrl+Down or Shift+Ctrl+Up key > > combination. I tested with Openoffice.org 3.0, works very well. Anybody testing > > the patch with braille display? > > Since this patch is in default.py, it will have an effect on every application. > So, please test with a variety of applications. Since the change you made is > isolated to spoken text only, testing with braille should not be necessary. Attila - just a reminder that I'm waiting for you to confirm that you've tested this with a variety of applications. Thanks!
Sorry Will, I not forget this bug. When I use for example with Gedit and write long text (automatic wordwrap lines, not using enter key), the Ctrl+Shift+Down key combination good select the whole paragraph. In openoffice.org the Ctrl+Shift+Down key combination works perfect, the paragraph is selected. But for example if I select Ctrl+Shift+down key combination with this text with Firefox in the additional comment edit box and not use enter key with wrap the lines, the Ctrl+Shift+Down select only the actual line. In Thunderbird, when I open an e-mail and try this key combinatgion, Ctrl+Shift+Down key combination select only the actual line, not the whole paragraph. So, my first patch is not good ydea I think, only enough the fixed message with Openoffice.org and Gedit. Or this problem in Firefox and Thunderbird is another bug? If yes, I open new bugreport, and describe this two problem (Ctrl+Shift+Down arrow key not select paragraphs in Firefox and Thunderbird). Attila
(In reply to comment #4) > But for example if I select Ctrl+Shift+down key combination with this text with > Firefox in the additional comment edit box and not use enter key with wrap the > lines, the Ctrl+Shift+Down select only the actual line. > In Thunderbird, when I open an e-mail and try this key combinatgion, > Ctrl+Shift+Down key combination select only the actual line, not the whole > paragraph. :-( Yep - seems like the behavior isn't consistent across toolkits. > So, my first patch is not good ydea I think, only enough the fixed message with > Openoffice.org and Gedit. > Or this problem in Firefox and Thunderbird is another bug? If yes, I open new > bugreport, and describe this two problem (Ctrl+Shift+Down arrow key not select > paragraphs in Firefox and Thunderbird). Opening a bug report in the Mozilla database would be a good thing. If they don't know about a bug, it will definitely never get fixed. Based upon my experiences with Mozilla and caret navigation issues, however, they will likely never address it. So, we will need to do something in Orca to workaround the bug. Maybe the Gecko script could override default.py:speakTextSelectionState to speak the 'line' version and default.py could be modified to speak the 'paragraph' version. If Mozilla ever fixed the Gecko bug, then we'd need to pull out the overridden method in the Gecko script.
Created attachment 138837 [details] [review] Patch to let the script define what strings should be used This patch lets the script define what strings should be used. Attila - please test.
Tested your patch. When I use Gedit and Openoffice.org Writer, the need message is correct. But I see one interesting think, I don't known why happen, possible this is not an Orca problem: I write two lines with Gedit and Openoffice.org writer: apple potato After this I press Ctrl+home key, and press one time with Ctrl+Shift+Down key combination. When I use Gedit, Orca says: potato paragraph selected down from cursor position If I do where am I command, Orca says: Apple potato selected. I think this is not good. When I try this test with openoffice.org, I see following: If I press one time the Ctrl+Shift+Down key combination, Orca says: "apple paragraph selected down from cursor position" When I do where am I operation, Orca says: "apple selected." This is the right method. Attila
(In reply to comment #7) > But I see one interesting think, I don't known why happen, possible this is not > an Orca problem: I think this is a separate bug.
Committed. Please open a separate bug for the other issue. Thanks!