After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585048 - gnote can lose notebook categorization, odd behaviour of notebook button
gnote can lose notebook categorization, odd behaviour of notebook button
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: main
0.4.x
Other Linux
: Normal normal
: 1.0
Assigned To: gnote-maint
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-07 10:18 UTC by VF
Modified: 2010-12-23 22:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Select notebook after creating list (2.22 KB, patch)
2010-08-28 21:14 UTC, Aurimas Černius
none Details | Review

Description VF 2009-06-07 10:18:29 UTC
How to reproduce:
1. Start Tomboy, create a note "Test Note", give it a notebook "Test"
2. close tomboy, run cp -r .tomboy .gnote to import the notes into gnote
3. Start gnote, open "Test Note"
4. Click the notebook icon on the toolbar

The note will now have lost its notebook, the icon on the toolbar changes to "Notebook" instead of "Test", and if the note is closed it will be Unfiled. If you click the Notebook dropdown and select Test again (even though the Test radio button already appears to be selected) the note will now be in the Test notebook and this bug will not be reproducable. In other words, it only happens for notes that have just been imported from tomboy, after they have been given a notebook in the gnote UI the notebook 'sticks'.
Comment 1 VF 2009-06-10 03:31:07 UTC
Actually this seems to happen for all the imported notes again after restarting gnote...
Comment 2 Hubert Figuiere (:hub) 2009-06-10 03:34:32 UTC
What distro?

What version of libxml++?
Comment 3 VF 2009-06-10 03:44:39 UTC
Fedora 11, libxml++ 2.26
Comment 4 Hubert Figuiere (:hub) 2009-07-16 21:22:15 UTC
I have committed a potential fix for the problem you are describing I'm unable to reproduce. Marking a FIXED.

If you can reproduce in any version after 0.5.3, please feel free to reopen, possibly with sample data. Thanks.
Comment 5 VF 2009-07-21 19:37:15 UTC
Unfortunately doesn't seem to be fixed, and seems to be the case for _any_ note, even created with gnote.

It's an odd little bug and I only care about it because of the potential for lost notebook categorization.

To reproduce:
1) Make sure you have a note that is associated with a notebook, then restart gnote.
2) Open ANY note as long as it has already been categorized with a notebook
3) Click the notebook button on the note. If it's categorized under "Stuff", the notebook icon will now just say "Notebook". If you click the "Notebook" button, the radio button for "Stuff" will be selected, however, if you go into the notes search window, it will appear under "Unfiled Notes" until you actually click "Stuff" again, at which point the notebook button will change back to be labelled "Stuff" and the note will be re-categorized. If you accidentally click the notebook button and then close the note before re-associating it, it now has lost its categorization.
Comment 6 Norman Petry 2009-07-21 22:43:53 UTC
I can confirm the bug as described in comment #5 exists in gnote-master (v.0.6).
Comment 7 Norman Petry 2009-07-21 22:55:15 UTC
I should add that this is with Ubuntu Jaunty and libxml++ 2.6-2 (2.26.0-2~ppajaunty1 package).

Comment 8 Hubert Figuiere (:hub) 2009-07-21 23:46:03 UTC
(In reply to comment #7)
> I should add that this is with Ubuntu Jaunty and libxml++ 2.6-2
> (2.26.0-2~ppajaunty1 package).
> 

libxml++ is no longer need, so the point is moot.
Comment 9 Pierre-Yves Luyten 2010-07-07 22:38:54 UTC
Reproduced with 0.7.2.
Comment 10 Aurimas Černius 2010-08-27 21:21:57 UTC
When clicking on "Notebook" button, "activated" signal occurs in "No notebook" item, if note is assigned to notebook. Then, if clicked somewhere outside to get menu closed, two more signal occur: first on current notebook item and second again on "No notebook". This results in note being removed from notebook.
Does anyone have any idea, why this happens?
I actually a little dislike the way this is currently implemented (I know it came from Tomboy, but ...), so I'll try to do some refactoring there, maybe this will lead somewhere (debugging has lead me only deeper into forest :().
Comment 11 Aurimas Černius 2010-08-28 21:14:40 UTC
Created attachment 168966 [details] [review]
Select notebook after creating list

If we select the right menu item in the same place we create them, it seems to work. In that case the selection code from menu item constructor can be removed.

This seems to work for me.
Comment 12 Aurimas Černius 2010-12-23 22:27:04 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.