Bug 585042 - Use accessor functions instead direct access
Use accessor functions instead direct access
Status: VERIFIED FIXED
Product: vino
Classification: Applications
Component: Preferences Dialog
2.28.x
Other All
: Normal normal
: ---
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
:
: 612499 (view as bug list)
Depends on: 612503
Blocks: 585391
  Show dependency tree
 
Reported: 2009-06-07 05:23 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-06-22 09:08 UTC (History)
4 users (show)

See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30

Attachments
Use accessor functions instead direct access (1.11 KB, patch)
2009-06-07 05:26 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Diff | Review
Patch fixing all but one issue (7.21 KB, patch)
2010-04-13 09:34 UTC, André Klapper 		rejected Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Javier Jardón (IRC: jjardon) 2009-06-07 05:23:53 UTC 
See http://live.gnome.org/GnomeGoals/UseGseal for more details
Comment 1 Javier Jardón (IRC: jjardon) 2009-06-07 05:26:22 UTC 
Created attachment 136077 [details] [review]
Use accessor functions instead direct access
Comment 2 Jonh Wendell 2009-06-07 19:13:17 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 André Klapper 2010-03-10 21:00:30 UTC 
*** Bug 612499 has been marked as a duplicate of this bug. ***
Comment 4 Javier Jardón (IRC: jjardon) 2010-03-10 21:28:28 UTC 
Reopening
Comment 5 André Klapper 2010-04-09 10:33:33 UTC 
gedit-spinner.c: In function ‘gedit_spinner_init’:
gedit-spinner.c:619: error: ‘GtkObject’ has no member named ‘flags’
gedit-spinner.c: In function ‘gedit_spinner_expose’:
gedit-spinner.c:640: warning: implicit declaration of function ‘GTK_WIDGET_DRAWABLE’
gedit-spinner.c:671: error: ‘GtkWidget’ has no member named ‘allocation’
gedit-spinner.c:672: error: ‘GtkWidget’ has no member named ‘allocation’
gedit-spinner.c:674: error: ‘GtkWidget’ has no member named ‘allocation’
gedit-spinner.c:675: error: ‘GtkWidget’ has no member named ‘allocation’
gedit-spinner.c:684: error: ‘GtkWidget’ has no member named ‘window’
gedit-spinner.c:685: error: ‘GtkWidget’ has no member named ‘window’
gedit-spinner.c:686: error: ‘GtkWidget’ has no member named ‘allocation’
gedit-spinner.c:687: error: ‘GtkWidget’ has no member named ‘allocation’
gedit-spinner.c: In function ‘gedit_spinner_start’:
gedit-spinner.c:734: warning: implicit declaration of function ‘GTK_WIDGET_MAPPED’
make[2]: *** [gedit-spinner.o] Error 1
make[2]: Leaving directory `/home/andre/svn-gnome/vino/capplet'
Comment 6 André Klapper 2010-04-13 09:34:09 UTC 
Created attachment 158583 [details] [review]
Patch fixing all but one issue

Bumps gtk+ requirement from 2.16 and 2.18.
Added three "#if GTK_CHECK_VERSION(2,20,0)" for gtk+ 2.20 API usage.

Only issue left to fix is "GTK_LABEL(url_label)->layout = NULL;"
in sexy-url-label.c. No idea what to do with that.
Comment 7 Milan Bouchet-Valat 2010-06-13 13:44:23 UTC 
Jonh, any chance you review the patch? It seems there's only one issue left! ;-)
Comment 8 Javier Jardón (IRC: jjardon) 2010-06-13 14:44:15 UTC 
I'd suggest you to use GtkSpinner, so you can get rid of the gedit-spinner part. See blocker bug
Comment 9 Jonh Wendell 2010-06-21 20:32:13 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 10 André Klapper 2010-06-22 09:08:13 UTC 
Thanks! Verified with fresh git master checkout.
Note You need to log in before you can comment on or make changes to this bug.