GNOME Bugzilla – Bug 585040
delete confirmation dialog is extremely annoying
Last modified: 2010-06-07 21:29:14 UTC
When I click the trash icon to delete a note, I mean it. I don't want you asking me stupid questions like whether I want to delete it or not. This annoyance alone is enough to make me not use Tomboy. Other information: You might want to implement a trash system (bug 382007), open since 2006!
(In reply to comment #0) > When I click the trash icon to delete a note, I mean it. I don't want you > asking me stupid questions like whether I want to delete it or not. This > annoyance alone is enough to make me not use Tomboy. I accidentally click things all the time, so I appreciate the dialog. But we could always add an option like "Don't ask me this again". Patches welcome, of course. I think I'll mark this a gnome-love bug. > Other information: > You might want to implement a trash system (bug 382007), open since 2006! Note that bug #382007 is unconfirmed, meaning that we have not yet committed to implementing it. Though I agree it would be easier to use than digging through ~/.tomboy/Backup. I'm removing the "usability" keyword because that is only used when you want feedback from the usability team.
I have a proof-of-concept patch ready for testing but my testing platform needs rebuilt first, which I hope to have done this weekend. Once I verify it works on my system, I'll attach the patch to the ticket for review.
Patch attached. Smoke tested against 0.14.0 and 1.1.0.
Created attachment 146772 [details] [review] patch to disable delete note confirmation dialog
Thanks for the patch, Jeff. I think instead of putting this in the prefs window, it would be better off as a "Don't ask me again" checkbox in the dialog itself. What do you think? Also, the modified .po files don't need to be part of the patch.
How would that work in the dialog? What if I wanted to turn confirmation back on again? (Just thinking out loud). I think in Preferences might make more sense.
I think they both make sense. Maybe you should have a "Don't ask me again" checkbox in the dialog and also an option in Preferences to enable/disable the dialog.
I've seen both ways in many other packages - putting the checkbox on the confirmation dialog itself vs putting it in a preferences dialog separate from the confirmation dialog. By having it on the preferences dialog, you allow users to get the old behavior back - always prompting to delete each note. Without this checkbox, a user would have to edit the gconf database, something non-technical users may not know about or how to do (akin to editing the registry in M$ Windows.) A reasonable trade off, IMHO, would be to keep the checkbox in the preferences dialog and add a checkbox to the confirmation dialog that sets the ENABLE_DELETE_CONFIRM setting in gconf. This alleviates the user from having to hunt down the setting in the Tomboy preferences dialog to disable it but gives them an easy (safer) avenue to re-enable the confirmation dialog. Thoughts?
Jeff, your approach (having the checkbox in both places) is probably the best approach, if we are going to expose this preference in the UI at all. I'm just not crazy about adding such a minor thing to the preferences window. Right now our preferences are very clean, and I'm not confident that more than a few people care about this feature. For now, let's just add the gconf preference with absolutely no UI (don't forget to add it in data/tomboy.schemas.in). Advanced users will be able to use gconf-editor to disable/enable the confirmation dialog. We can worry about exposing this preference in the UI later, if there is continued demand.
Created attachment 146786 [details] [review] patch to add gconf key for suppressing the "Delete Note" confirmation dialog This patch adds a key to gconf that allows the user to suppress the "Delete this note" dialog. There is no UI component for toggling this setting (must be done using gconf-editor.) Smoke tested against trunk on Ubuntu 9.10, 64-bit.
Review of attachment 146786 [details] [review]: A few minor things need to be fixed, then this is good to go. ::: Tomboy/Note.cs @@ +1447,2 @@ string message; + if (! (bool) Preferences.Get (Preferences.ENABLE_DELETE_CONFIRM)) { Check for it to be true, not false. ::: Tomboy/Preferences.cs @@ +86,3 @@ return true; + return false; + case ENABLE_DELETE_CONFIRM: Should be true ::: data/tomboy.schemas.in @@ +112,3 @@ + <owner>tomboy</owner> + <applyto>/apps/tomboy/enable_delete_confirm</applyto> + <key>/schemas/apps/tomboy/enable_delete_confirm</key> Should default to true. The name here is "enable_delete_confirm", so when true, the confirmation dialog will be shown. @@ +114,3 @@ + <owner>tomboy</owner> + <applyto>/apps/tomboy/enable_delete_confirm</applyto> + <key>/schemas/apps/tomboy/enable_delete_confirm</key> Let's say "Enable" instead of "Toggle" here. @@ +116,3 @@ + <owner>tomboy</owner> + <applyto>/apps/tomboy/enable_delete_confirm</applyto> + <key>/schemas/apps/tomboy/enable_delete_confirm</key> Let's say "disabled" here instead of "checked"
Created attachment 148195 [details] [review] patch to add gconf key for suppressing the "Delete Note" confirmation dialog Reversed boolean logic and changed wording in gconf locale text. Smoke tested against head.
We can decide at a later date if we want to expose this in the UI or not.