After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584837 - Find dialog fails to move caret to desired location in Thunderbird
Find dialog fails to move caret to desired location in Thunderbird
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.27.x
Other All
: Normal normal
: 2.26.3
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404409
 
 
Reported: 2009-06-04 15:36 UTC by David Price
Modified: 2009-06-22 01:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
debug log (232.64 KB, text/plain)
2009-06-04 15:42 UTC, David Price
  Details
Example message (49.37 KB, message/rfc822)
2009-06-04 15:46 UTC, David Price
  Details
Example message (49.37 KB, message/rfc822)
2009-06-04 15:53 UTC, David Price
  Details
proposed patch (996 bytes, patch)
2009-06-20 20:15 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description David Price 2009-06-04 15:36:15 UTC
Please describe the problem:
When using the Find dialog (control-F) in a mail message in Thunderbird (3.0b3pre),everything works as expected until the Escape key is pressed, after which the carat is moved to the top of the email message, even if the starting point for the search was not at the start of the message. This is happening using Orca from git, pulled today (4 June 2009).  The underlying version of gnome has no impact, as I can replicate this problem in both 2.24 and 2.26.

Steps to reproduce:
1. Start Orca 
2. Start Thunderbird 
3. Open a message 
4. Open the Find dialog using control-F 
5. type in the first few characters of a search string and listen to the target location within the message
6. Press the Escape key to exit the Find dialog 
7. Determine your current position within the message 


Actual results:
The carat is always placed at the beginning of the email message 

Expected results:
the carat should be placed on the string searched for within the Find dialog 

Does this happen every time?
yes 

Other information:
Comment 1 David Price 2009-06-04 15:42:47 UTC
Created attachment 135950 [details]
debug log 

Debug log showing behavior of the Find dialog. Log begins in Thunderbird message list. A message is focused and opened, with the carat being placed at the top of the message. The Find dialog is opened and the search string "top" is entered. Orca reads "Top Stories" as the target of the find. Escape is pressed, and the carat is placed at the top of the message. Cursor down to the line containing "Top Stories". Open find dialog and enter string "world". Press enter numerous times until the "World" section heading is found. Press Escape. Carat is placed at top of message. Cursor down to top stories line. Example email message will be atached.
Comment 2 David Price 2009-06-04 15:46:11 UTC
Created attachment 135951 [details]
Example message 

This example was handy. However, this problem can be replicated using any HTML message in Thunderbird.
Comment 3 David Price 2009-06-04 15:53:16 UTC
Created attachment 135952 [details]
Example message 

This example was handy. However, this problem can be replicated using any HTML message in Thunderbird.
Comment 4 Willie Walker 2009-06-16 01:59:16 UTC
Marking this one for 2.28 so it doesn't fall off our radar screen.  We'll try to get to it for 2.28 unless someone else wants to beat us to it.  ;-)
Comment 5 Joanmarie Diggs (IRC: joanie) 2009-06-16 05:07:13 UTC
Assigning to myself and moving up. This one shouldn't be too much work.
Comment 6 Joanmarie Diggs (IRC: joanie) 2009-06-20 20:15:02 UTC
Created attachment 137084 [details] [review]
proposed patch

Figured this one would be easy. Will please review.
Comment 7 Willie Walker 2009-06-22 01:25:20 UTC
(In reply to comment #6)
> Created an attachment (id=137084) [edit]
> proposed patch
> 
> Figured this one would be easy. Will please review.

Looks simple and isolated.  I say commit to trunk and gnome-2-26.  Many thanks!
Comment 8 Joanmarie Diggs (IRC: joanie) 2009-06-22 01:54:55 UTC
Thanks Will. Committed to both.