After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584704 - External MP3 players should delete files rether than move to trash
External MP3 players should delete files rether than move to trash
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Removable Media
0.11.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 406002 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-06-03 11:34 UTC by Dave Martin
Modified: 2010-01-13 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dave Martin 2009-06-03 11:34:56 UTC
If I have a USB flash type MP3 player full of files, I move to trash from within rhythmbox to free up space to add new files but I can't as the files are still on the device. I need to go to my desktop, empty the trash to free up the space then come back to rhythmbox to add files. This adds an unnecessary (and annoying) step into the workflow.

Another scenario where this causes problems is if I delete (move to trash) files then unmount the device without emptying the trash. There is no option to empty trash on unmount so the trash folder in the device is left full.

It would make much more sense for external MP3 players to physically delete the files rather than do a move to trash. At the very least have a configurable option to allow hard deletion on external players or a context menu item to allow emptying trash from within rhythmbox.
Comment 1 Jonathan Matthew 2009-06-03 11:37:30 UTC
The 'remove' menu item deletes files.
Comment 2 Dave Martin 2009-06-03 13:17:21 UTC
Correct me if I am wrong but in the main library, the remove option removes a file from the library without deleting the physical file (if I may quote from the RB help)- 

To remove a track from the library but leave it on the disk, choose menu
			Edit ▸ Remove.
			The track and its properties (like rating or the play count) are removed from the Rhythmbox database.

In which case to have Remove in the library remove but leave the physical file and remove in an external player delete the file is inconsistent behaviour.

This inconsistency should be resolved. My preference would be for the external player context menu to be renamed "Delete from player" or just "Delete" to better reflect what it does and to resolve the inconsistency.
Comment 3 Jonathan Matthew 2009-12-28 09:28:21 UTC
*** Bug 406002 has been marked as a duplicate of this bug. ***
Comment 4 Jonathan Matthew 2010-01-13 13:12:28 UTC
commit 02ebefae3bc6ed7d76433ad04fed0c47f221276f
Author: Jonathan Matthew <jonathan@d14n.org>
Date:   Wed Jan 13 22:58:09 2010 +1000

    generic-player: remove 'move to trash', only allow deletion (bug #584704)
    
    Trashing files on generic audio players isn't very useful, as the files
    still take up space on the device and so they need to be cleaned up
    manually if the device is full.