GNOME Bugzilla – Bug 584444
Use tabs instead of dropdown list in sidebar
Last modified: 2009-11-09 09:28:03 UTC
At the moment I need two clicks to change the sidebar content. This is unnecessary I think. Should be done with one click. With tabs instead of this dropdown list (or additionally) this will be much easier. We can keep the dropdown for the case that there will be much more tabs. Other information:
see http://gitorious.org/~paulwb/f-spot/paulwbs-clone/commit/e3ca7f86c8ab03e28c00217d52f1a3a3c253d7d9, second file. Just one line.
This patch does not keep the dropdown and the tabs in sync. Of course, the tabs are changing if you change the dropdown lists, but viceversa the dropdown does not change.
Created attachment 135728 [details] Screenshot of tabbed sidebar In my opinion there is space enought for tabs.
Created attachment 135733 [details] F-Spot with default Gnome theme on 800x600 Another example. For the three tabs we have at the moment this is enough space.
Created attachment 135734 [details] Behaviour of tabbed sidebar on browse mode In browse mode the tabbed sidebar behaves strange. The tabs go more to the right than they should do.
Created attachment 135735 [details] Tabbed sidebar with little space in view mode Behaviour of tabbed sidebar in view/edit mode. Seems ok. Additional tabs are hidden if there is not enough space. If we keep with the drop down list, this is no issue. I think this is the expected behaviour.
http://gitorious.org/~paulwb/f-spot/paulwbs-clone/commit/952ad469fdc72151f3d23473710f91d4eeab17bf
This branch works fine. http://gitorious.org/~paulwb/f-spot/paulwbs-clone/commits/tabbedsidebar
Created attachment 136010 [details] Screenshot with scroll arrows and context menu See http://gitorious.org/~paulwb/f-spot/paulwbs-clone/commits/tabbedsidebar,0
I commited the last modification last week on this. http://gitorious.org/~paulwb/f-spot/paulwbs-clone/commits/tabbedsidebar It works fine now. It is configurable with your configuration backend, using the boolean key "ui/tabbed_sidebar". Default is "True". Stephane pointed out that the borders of the notebook pages of the sidebar are "ugly" (not matching the IconView border) using the tabs. This is caused because of the bevel borders enabled if tabs are shown. Setting ShowBorder to false does not have any effect if tabs are used. See http://library.gnome.org/devel/gtk/unstable/GtkNotebook.html#gtk-notebook-set-show-border. It depends on the theme you are using how this is handled. There are themes showing the bevel border always and others where you can influence the bevel border by setting the border width of the first child within the notebook change to 0 or 1. Anyway, this isn't nice. Some screenshots here: http://picasaweb.google.com/pwellner/FSpot# Does someone know a way to influence the notebook border with visible tabs? This would be perfect. If not (I fear this isn't possible without touching the gtk(#) code or implement an own tab display, but I may be wrong), would this be a blocker to include tabs in f-spot? At least deactivated as default?
I found a not-so-beautiful workaround for this border "problem". See screenshots here: http://picasaweb.google.com/pwellner/FSpot
Although I'd like to have this option in core f-spot (configurable), for now I wrote an extension doing this job. http://blog.wbou.de/f-spot