GNOME Bugzilla – Bug 584286
Request: icons for XDG user directories
Last modified: 2010-02-04 19:02:45 UTC
Hello, in bug #541276 we are trying to patch glib/gio, so that EVERY file-manager based on glib/gio will have specific icons for xdg-user directories (and of course the GtkFileDialog as well). Currently the only icons provided by gnome are home and desktop and it could be a good improvement to expand the xdg icon set, so that users will find the right directory with a visual hint too. So our request is to add new names to the icon-naming-spec, and draw a default set of icons (the proposed names can be changed of course): - xdg-document-dir / Directory corresponds to XDG_DOCUMENTS_DIR - xdg-pictures-dir / Directory corresponding to XDG_PICTURES_DIR - xdg-music-dir / Directory corresponding to XDG_MUSIC_DIR - xdg-videos-dir / Directory corresponding to XDG_VIDEOS_DIR - xdg-downloads-dir / Directory corresponding to XDG_DOWNLOAD_DIR - xdg-templates-dir / Directory corresponding to XDG_TEMPLATES_DIR - xdg-publicshare-dir / Directory corresponding to XDG_PUBLICSHARE_DIR
I think this bug should be assigned to dobey.pwns@gmail.com
The suggested names aren't spec compliant (if you're already using them). They would be folder-foo instead as the rest of the folder icons in the spec are. Ideally though, these would all just be the folder icon with an appropriately named emblem composited on them (folder + emblem-photos for example).
Really thanks for your interest on this problem. I will immediately update the name to folder-foo in my patch. Some developer (in the glib bug) said that he prefers to not use emblems, because in this way the image will have a better representation (think of the small icons in the places panel menu, if you put embelms in those they won't be visible because of the size). Exactly for the same reason they switched from emblems to a completely redrawn icon for Desktop and Home. What do you think of this?
Emblems are imho not a good idea for this. First of all they are already overloaded in that they are used for a lot of things and we need to streamline emblem use rather than add further usecases for it. Furthermore, a standard folder icons is just not always what you want. For instance, none of the current similar icons (user-home, user-desktop or user-trash) are implementable as folder + icon, neither are the proposals at http://live.gnome.org/GnomeArt/ArtRequests/issue26 Also, the folder-* name doesn't seem to match the similar icons i listed above, aren't user-* a better namespace here?
Mmm, in fact the home dir is user-home, the trash is user-trash, and the desktop is user-desktop. Rodney, what do you think?
Created attachment 136404 [details] [review] icons-glib-patch.patch This patch adds an important feature: - fallback "folder" icon when the current theme does not have the requested icon (nautilus has problems with it, so we need nautilus developers to fix it before committing this patch) - changed from "folder-foo" to "user-foo" as it makes more sense (thanks alex) still need a comment from the icon naming spec developer
woops, wrong bug, sorry!
From the XDG list: it's better "folder-foo" so that if the theme does not have "folder-foo", it will fallback to "folder" this also simplify the code by using the gio function g_themed_icon_new_with_default_fallbacks I will update my patch as soon as I get back home
The patch has been committed. That's great. Now we should try to add those names to the icon naming spec, so that they will be included in icon themes. To remind you, this was the final decision: - folder-documents - folder-download - folder-music - folder-pictures - folder-publicshare - folder-publicshare - folder-videos Rodney Dawes: your help is needed now
confirming, fedora and ubuntu are now shipping such XDG user directories icons. Would be nice to have similar icons for upstream. maybe this bug should be reassigned to gnome-art team ? http://live.gnome.org/GnomeArt/ArtRequests/issue26
XDG folder icons are now in git master (2.29.x). Jakub, Rodney, OK to close this bug?
Oh, indeed.