After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584135 - "No audio" gets changed to some audio improperly; handle properly timelines without audio or without video
"No audio" gets changed to some audio improperly; handle properly timelines w...
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Rendering
Git
Other All
: Normal blocker
: 0.13.4
Assigned To: Pitivi maintainers
Pitivi maintainers
: 597830 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-05-28 16:20 UTC by Vadim Peretokin
Modified: 2010-02-21 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Vadim Peretokin 2009-05-28 16:20:38 UTC 
Please describe the problem:
Pitivi changes an option without the users consent

Steps to reproduce:
1. Add ogg to timeline, no audio
2. Go to render - says "no audio" for audio. ok.
3. Go to "modify" and OK - now there is some audio! While we did not add it.


Actual results:


Expected results:


Does this happen every time?


Other information:
video: http://drop.io/hdf5xso
Comment 1 Edward Hervey 2010-02-10 14:45:19 UTC 
*** Bug 597830 has been marked as a duplicate of this bug. ***
Comment 2 Edward Hervey 2010-02-10 14:46:00 UTC 
Also fails with 0.13.3 and git
Comment 3 Jean-François Fortin Tam 2010-02-15 18:01:05 UTC 
Retitling for clarity, because if you try to render without audio, pitivi will hang trying to render (Bug #597830). In cases like that, pitivi should automatically disable rendering the audio (partly related to bug #590639, but not a duplicate since that one requests a UI feature for overriding pitivi's detection).
Comment 4 Alessandro Decina 2010-02-21 00:03:07 UTC 
commit 22d4ecf784c9094ff7118f981953c7064a818e3f
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Sun Feb 21 01:00:42 2010 +0100

    In the encoding dialog, show "no audio" if audio isn't available. Fixes #584135.

commit 23ec69353ceb2f7a40a00c8dd7c5e95558559be7
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Sun Feb 21 00:53:00 2010 +0100

    Make rendering video only or audio only work again. Partly fixes #584135.
Comment 5 Jean-François Fortin Tam 2010-02-21 04:47:14 UTC 
I think you forgot to test :)

This is what happens when accessing the rendering dialog in pitivi git now:


Traceback (most recent call last):

+ Trace 220658

  • File "pitivi/ui/mainwindow.py", line 234 in _recordCb 
    self.showEncodingDialog(self.project)
  • File "pitivi/ui/mainwindow.py", line 225 in showEncodingDialog 
    win = EncodingDialog(self, project)
  • File "pitivi/ui/encodingdialog.py", line 73 in __init__ 
    self.detectStreamTypes()
  • File "pitivi/ui/encodingdialog.py", line 186 in detectStreamTypes 
    assert isinstance(timeline_source, TimelineSourceFactory) AssertionError
  • File "pitivi/ui/encodingdialog.py", line 153 in _settingsButtonClickedCb 
    dialog = ExportSettingsDialog(self.app, self.settings)
AttributeError: 'EncodingDialog' object has no attribute 'settings' 



And if you try to click the Close button: 

Traceback (most recent call last):
  File "pitivi/ui/encodingdialog.py", line 174, in _cancelButtonClickedCb
    self._shutDown()
  File "pitivi/ui/encodingdialog.py", line 87, in _shutDown
    self.removeRecordAction()
  File "pitivi/ui/encodingdialog.py", line 221, in removeRecordAction
    self.debug("renderaction %r", self.renderaction)
AttributeError: 'EncodingDialog' object has no attribute 'renderaction'
Comment 6 Alessandro Decina 2010-02-21 12:55:32 UTC 
commit 9853b5cdeab9ebd05cbcc583969ae1c685ff20f6
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Sun Feb 21 13:40:52 2010 +0100

    Some more fixes for #584135.