After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583919 - New conversation should have autocomplete for offline contacts too
New conversation should have autocomplete for offline contacts too
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.27.x
Other All
: Normal minor
: ---
Assigned To: empathy-maint
empathy-maint
: 595731 (view as bug list)
Depends on: 600537
Blocks:
 
 
Reported: 2009-05-26 18:02 UTC by Praveen Thirukonda
Modified: 2009-11-09 12:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28

Attachments
patch (976 bytes, patch)
2009-11-02 14:57 UTC, justin.forest 		none Details | Review

Description Praveen Thirukonda 2009-05-26 18:02:19 UTC 
in empathy going in chat->new conversation the dialogue which pops up has auto complete support for only online contacts this seems to be very wrong as mostly this dialogue will be used for offline contacts as online ones are usually accessed by clicking on their names.
 pidgin does it that way. 

Other information:
Comment 1 Guillaume Desmottes 2009-06-23 14:16:14 UTC 
Make sense.
Comment 2 justin.forest 2009-11-02 14:57:17 UTC 
Created attachment 146752 [details] [review]
patch

This is actually quite simple.
Comment 3 Guillaume Desmottes 2009-11-03 11:53:01 UTC 
Thanks for your patch Justin!
I pushed a better patch to http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/conversation-offline-583919
there is no need to keep the "if".

I'll test it once bug #600537 as been fixed.
Comment 4 Guillaume Desmottes 2009-11-03 12:24:46 UTC 
Merged to master. Thanks for your contribution !

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

commit a97016255a79a5b26af59411eab907d2881bc63e
Author: Justin Forest <justin.forest@gmail.com>
Date:   Mon Nov 2 17:54:01 2009 +0300

    Autocomplete for offline contacts. Closes bug #583919.
Comment 5 Guillaume Desmottes 2009-11-09 12:40:40 UTC 
*** Bug 595731 has been marked as a duplicate of this bug. ***