GNOME Bugzilla – Bug 583918
glade files are a mess
Last modified: 2009-06-03 19:34:57 UTC
While I was trying to fix some HIG problems in the connection editor dialogues (which I will submit as separate bugs after this one is done), I found that the glade files are saved with a mix of glade-2 and older glade-3. Re-saving the older glade-3 files with new glade-3 produces a big diff (and re-saving the glade-2 files with glade-3 an even bigger diff). That makes patches unreviewable, of course. So I'd like to suggest to either - re-save all files without changes using latest glade-3, or - re-save all files with glade-2 (and fixup the tooltip-text property) (my preferred option). As an added complication, new glade-3 doesn't work on some of the glade-3 files since it refuses to save the "tooltip-text" property to glade format (e.g. ce-page-ip4.glade has this problem). Which option do the maintainers prefer?
glade-3 is the way forward until we convert to GtkBuilder in the future. That's *assuming that older libglade can still read the files* of course; the applet supports back to libglade 2.6.2 and maybe earlier. Can't do much about the glade-3 version differences, if glade-3 is changing their format between versions that much that it produces a huge diff, then something is wrong with the glade-3 folks :)
libglade can read the files, yes. But as I said, just loading ce-page-ip4.glade in glade-3 and saving again without any changes gives a warning dialogue and strips the tooltip-text properties. I think we can work around that by using the "tooltip" property which libglade understands (and glade-3 also understands). So should I submit a patch that just does that and re-saves all glade files with glade-3, to establish a baseline for further HIGification patches, making these patches at least somewhat reviewable? (I agree about glade-3 being wrong in producing big diffs, but the glade-3 folks unfortunately don't see diffability as a worthwhile thing.)
Sure, sounds fine. Thanks! I greatly appreciate the work you do.
Created attachment 135409 [details] [review] patch series I split this up in several parts to make it easier to see that everything's correct: 1/4 re-save in a patched glade-3 that does not change the enum properties 2/4 re-save with glade-3 without the above patch (but still patched wrt. tooltip_text) 3/4 re-introduce some tooltips that got lost when saving the glade-2 file with glade-3, unexplicably (glade-3 bug?) 4/4 convert tooltip_text to tooltip property for unpatched glade-3 compatibility As far as I can tell, everything's still working alright. Saving the glade-2 to glade-3 possibly broke some widget alignments, but I'll fix that up in the HIGification patches to come.
committed, thanks