After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583796 - use the gphoto/gvfs backend for the photo importer
use the gphoto/gvfs backend for the photo importer
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
: 587024 (view as bug list)
Depends on:
Blocks: 583464
 
 
Reported: 2009-05-25 12:32 UTC by Michael Chudobiak
Modified: 2009-06-26 09:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Chudobiak 2009-05-25 12:32:24 UTC 
We should use the gphoto/gvfs backend for the photo importer, instead of libgphoto directly.

Pre-import thumbnails can be obtained using the G_FILE_ATTRIBUTE_PREVIEW_ICON attribute (a GIcon that you can use with e.g. gtk_image_set_from_gicon).

- Mike
Comment 1 Michael Chudobiak 2009-05-25 12:46:58 UTC 
The build files will need to be tweaked to make the gphoto backend mandatory (unless disabled with a compile flag).

- Mike
Comment 2 Matthias Hawran 2009-05-27 12:02:16 UTC 
Mike,

Please elaborate on this change (pros & cons).

And why is it a stopper for 2.11.0 ?

Thanks,
Matthias
Comment 3 Michael Chudobiak 2009-05-27 13:13:01 UTC 
Well, this one is debatable. Let's call it a semi-blocker.

It's a fairly big change to switch from libgphoto to gvfs, so it would be nice to have it in from the beginning of the 2.11.x series, and refine it with further releases, rather than introducing a major change in the middle of a release series.

- Mike
Comment 4 Matthias Hawran 2009-05-27 13:33:52 UTC 
Fair enough for the block point. It makes sense.

However I don't understand the use of gphoto instead of libgphoto.
That means system calls, instead of library calls.
Isn't that less efficient ?

Matthias
Comment 5 Michael Chudobiak 2009-05-27 13:37:49 UTC 
Matthias,

The background info is here:

http://mail.gnome.org/archives/gvfs-list/2009-May/msg00001.html

- Mike
Comment 6 Michael Chudobiak 2009-06-08 19:03:55 UTC 
This is now in trunk. Request for improvements can be filed as separate bugs.

- Mike
Comment 7 Michael Chudobiak 2009-06-26 09:35:59 UTC 
*** Bug 587024 has been marked as a duplicate of this bug. ***