GNOME Bugzilla – Bug 583499
Decompression of cbz files with p7zip
Last modified: 2011-07-01 19:33:21 UTC
Until now evince decompress cbz files with unzip. It'd be nice add support for decompressing cbz files with p7zip commands.
Created attachment 135142 [details] [review] Decompression of cbz files with p7zip. Fixes #583499 Also "fixes" some indentation problems of the adjacent lines
Why exactly it would be nice?
Sorry, I think I wrote a stupid bug and not very "nice" report :) What I mean is you can decompress a cbz file without unzip, just using p7zip. Right now, p7zip is used only for decompressing cb7 files; but you can decompress cbz files too if you don't have unzip installed. This way, you give more options to the users and less problems.
s/bug and not very "nice" report/and not very "nice" bug report
I can hardly imagine the environment without unzip. I think we can leave is as is without complicating the code with more execution branches.
Review of attachment 135142 [details] [review]: So, would this work if you have unzip installed but not 7z?
The idea was for using p7zip for opening zip files (cbz) in case you don't have unzip as a second option. If you think we should add this option, I can check the patch in master.
if it's used as a fallback when unzip is not installed, it's ok to me.
Carlos, Here you are the git formatted patch
Created attachment 191037 [details] [review] fallback mode for cbz files using 7za and 7z
I pushed the patch to master