After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583213 - [PATCH] Don't add trailing spaces when generating a Doxyfile
[PATCH] Don't add trailing spaces when generating a Doxyfile
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: general
unspecified
Other All
: Normal trivial
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2009-05-19 13:47 UTC by Alejandro
Modified: 2009-08-20 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't add trailing spaces when generating a Doxyfile (against svn trunk r692) (278.47 KB, patch)
2009-05-19 13:49 UTC, Alejandro
none Details | Review
Fixed patch (against svn trunk r692) (278.44 KB, patch)
2009-05-19 17:33 UTC, Leandro Lucarella
none Details | Review

Description Alejandro 2009-05-19 13:47:52 UTC
Trailing spaces tend to be problematic because they "pollute" diffs and are commonly seen as a "bad practice". There even are some SCM hooks that check for trailing spaces and reject changesets if they have any.

doxygen -g and doxygen -u both creates a Doxyfile with trailing spaces, which can be really annoying in that scenarios.

Attached is a patch to avoid adding trailing spaces when doxygen generates a Doxyfile.
Comment 1 Alejandro 2009-05-19 13:49:26 UTC
Created attachment 134937 [details] [review]
Don't add trailing spaces when generating a Doxyfile (against svn trunk r692)
Comment 2 Leandro Lucarella 2009-05-19 14:18:17 UTC
The patch should be applied with patch -p1 BTW (I made the patch, not Alejandro, I've used a "bugmenot" account to fill the bug report and then remembered I had my own account in this bugzilla =).
Comment 3 Leandro Lucarella 2009-05-19 17:33:30 UTC
Created attachment 134959 [details] [review]
Fixed patch (against svn trunk r692)

Here is a new version of the patch that fixes a double space that was introduced for list options.
Comment 4 Dimitri van Heesch 2009-08-14 08:23:14 UTC
Thanks for the patch. I'll include it in the next subversion update.
Comment 5 Dimitri van Heesch 2009-08-20 10:12:45 UTC
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.6.0. Please verify if this is indeed the case and reopen the
bug if you think it is not fixed (include any additional information that you
think can be relevant).