After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583029 - The gdk_pixbuf_composite_color function uses wrong checkboard offset
The gdk_pixbuf_composite_color function uses wrong checkboard offset
Status: RESOLVED OBSOLETE
Product: gdk-pixbuf
Classification: Platform
Component: pixops
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-18 08:59 UTC by Andrey Tsyvarev
Modified: 2018-05-22 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test for verify correctness of checkboard offset (1.40 KB, text/plain)
2009-05-18 09:03 UTC, Andrey Tsyvarev
Details

Description Andrey Tsyvarev 2009-05-18 08:59:41 UTC
From the description of gdk_pixbuf_composite_color:
Creates a transformation of the source image src by scaling by scale_x and scale_y then translating by offset_x and offset_y, then composites the rectangle (dest_x ,dest_y, dest_width, dest_height) of the resulting image with a checkboard of the colors color1 and color2 and renders it onto the destination image.

There is also a note about the origin of the checkboard in the description of check_x parameter:
origin of checkboard is at -check_x, -check_y 

However gdk_pixbuf_composite_color is implemented so, that the checkboard is shifted by dest_x and dest_y before composition with the source image. So the actual position of the checkboard's origin is (dest_x-check_x, dest_y-check_y) when composition is performed.
Comment 1 Andrey Tsyvarev 2009-05-18 09:03:11 UTC
Created attachment 134854 [details]
test for verify correctness of checkboard offset

If checkboard offset is not depend from dest_x and dest_y parameters, then both resulting images should be the same.
Comment 2 Bastien Nocera 2014-10-22 12:52:17 UTC
Reproduce with 2.31
Comment 3 GNOME Infrastructure Team 2018-05-22 13:10:16 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gdk-pixbuf/issues/22.