After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582918 - Policy file strings are not translatable
Policy file strings are not translatable
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other All
: Normal minor
: ---
Assigned To: Dan Williams
Dan Williams
Depends on:
Blocks:
 
 
Reported: 2009-05-17 07:35 UTC by David Planella
Modified: 2009-06-22 19:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Mark policy file strings for translation (3.69 KB, patch)
2009-05-17 07:39 UTC, David Planella 		none Details | Review

Description David Planella 2009-05-17 07:35:27 UTC 
Please describe the problem:
Forwarded from Ubuntu at https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/361109:

[...]
"Steps to reproduce:

1. Open the Network Manager Connection Editor (nm-connection-editor).
2. Select a wired connection and click on Edit.

A dialog appears asking you to enter your password. That dialog shows the "System policy prevents modification of system settings" message untranslated"
[...]

This is due to strings in the policy/org.freedesktop.network-manager-settings.system.policy file not being marked for translation.

A patch fixing this issue follows.

Steps to reproduce:



Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 David Planella 2009-05-17 07:39:03 UTC 
Created attachment 134797 [details] [review]
Mark policy file strings for translation

This patch fixes the issue by marking the relevant strings in the policy file for translation and adapting the build system (Makefile.am and POTFILES.in) accordingly.
Comment 2 David Planella 2009-06-21 16:52:16 UTC 
Ping. Any news? Could someone review the patch?

Thanks.
Comment 3 Dan Williams 2009-06-22 15:53:52 UTC 
commit 93e02fa759d35efbb8242f0a7f03fc927404ff99
Author: David Planella <david.planella@googlemail.com>
Date:   Mon May 18 17:33:05 2009 -0400

Sorry, long committed, I must not have updated the bug.
Comment 4 David Planella 2009-06-22 19:17:43 UTC 
Dan,

Thanks for committing this.