Bug 582504 - Use GtkBuilder instead of libglade
Use GtkBuilder instead of libglade
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: Gerd Kohlberger
David Bolter
:
Depends on:
Blocks: 572883 112974
  Show dependency tree
 
Reported: 2009-05-13 17:38 UTC by André Klapper
Modified: 2009-10-09 15:22 UTC (History)
2 users (show)

See Also:
GNOME target: 2.30.x
GNOME version: ---


Attachments
Migrate to GtkBuilder (564.86 KB, patch)
2009-10-08 21:10 UTC, Gerd Kohlberger
accepted-commit_now Details | Diff | Review

Description André Klapper 2009-05-13 17:38:19 UTC
According to http://www.gnome.org/~fpeters/299.html
this module depends on libglade.

In GNOME 2.27, libglade has been deprecated in favor of GtkBuilder. See
http://library.gnome.org/devel/gtk/stable/gtk-migrating-GtkBuilder.html for
migration instructions. Also see
http://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder
Comment 1 David Bolter 2009-05-14 00:46:07 UTC
Thanks André. Reassigning to Gerd. Gerd we should probably make you the default assignee for GOK bugs... if you want to file for that I'll bless it.
Comment 2 Gerd Kohlberger 2009-05-14 17:55:21 UTC
David, how about changing the default assignee and QA back to a module alias - gok-maint@gnome.bugs. That way anyone who's interested in GOK can just watch that address and get notifications. It would also leave new bugs initially unassigned to indicate that no one is actively working on it at the moment.
Comment 3 André Klapper 2009-05-14 18:41:28 UTC
Please file a bug against bugzilla.gnome.org in bugzilla.gnome.org if you want an alias.
Comment 4 Gerd Kohlberger 2009-05-14 18:56:02 UTC
André, I thought every bugzilla product automatically has such an alias. Is this not the case? I'm asking because we use a similar address in mousetweaks (mousetweaks-maint@gnome.bugs) and I never filed a bug for that.
Comment 5 André Klapper 2009-05-14 19:08:52 UTC
No, it's not automatically. It's pure, manual work. :-)
Comment 6 Ben Konrath 2009-09-01 22:39:53 UTC
Gerd, Did you ever get the gok-maint@gnome.bugs alias set up? I'd like to follow the gok bugs. Thanks! Ben
Comment 7 Gerd Kohlberger 2009-09-02 10:31:46 UTC
Hi Ben, I've opened a bug for it now.
http://bugzilla.gnome.org/show_bug.cgi?id=593891

In the meantime I've added your account to the default CC list for new bugs and to the 'gok Developers' group.
Comment 8 Gerd Kohlberger 2009-09-03 17:10:09 UTC
gok-maint@gnome.bugs is now the default assignee/QA.
Comment 9 Gerd Kohlberger 2009-10-08 21:10:03 UTC
Created attachment 145080 [details] [review]
Migrate to GtkBuilder
Comment 10 Ben Konrath 2009-10-08 22:46:35 UTC
Comment on attachment 145080 [details] [review]
Migrate to GtkBuilder

Gerd, I looked over the patch - great job cleaning stuff up! 

I also compiled and ran gok with your patch and it worked great. Thanks! Ben
Comment 11 Gerd Kohlberger 2009-10-09 15:22:45 UTC
Thanks for the review Ben. I've committed the patch to master.

http://git.gnome.org/cgit/gok/commit/?id=68ae0133f69e258067888db38ff681204bf1c1f9

Note You need to log in before you can comment on or make changes to this bug.