After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582311 - Add hardware tab
Add hardware tab
Status: RESOLVED DUPLICATE of bug 398036
Product: system-monitor
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Benoît Dejean
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-12 12:21 UTC by Vincent Untz
Modified: 2012-12-08 00:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
openSUSE patch (18.58 KB, patch)
2009-05-12 12:21 UTC, Vincent Untz
none Details | Review
updated patch (21.33 KB, patch)
2009-05-12 20:31 UTC, Benoît Dejean
committed Details | Review

Description Vincent Untz 2009-05-12 12:21:17 UTC
In openSUSE, we have a patch to add a hardware tab listing the hardware on the computer. Attaching the patch.
Comment 1 Vincent Untz 2009-05-12 12:21:50 UTC
Created attachment 134491 [details] [review]
openSUSE patch
Comment 2 Benoît Dejean 2009-05-12 20:31:41 UTC
Created attachment 134525 [details] [review]
updated patch

Very nice patch.
I have updated it, completed a few more things.

Comments:
- filling the hardware list in a thread seems totally broken, i've disabled it
- in the system info tab

+    /* system info */
+    string bios_version;
+    string bios_date;
+    string machine_type_model;
+    string system_serial;
+    string system_board_serial;

are defined but only type_model is displayed and may not be filled. What about also displaying the other fields ?

- do you think libhd is portable enough, not to suse-centric ? Any chance it works on solaris, *bsd, etc ?
Comment 3 Vincent Untz 2009-05-12 23:22:16 UTC
Hi,

First, I didn't write the patch, I'm merely forwarding the work Hubert did :-) So all credit should go to him.

(In reply to comment #2)
> - in the system info tab
> 
> +    /* system info */
> +    string bios_version;
> +    string bios_date;
> +    string machine_type_model;
> +    string system_serial;
> +    string system_board_serial;
> 
> are defined but only type_model is displayed and may not be filled. What about
> also displaying the other fields ?

I've no strong opinion there, as long as the UI is fine.

> - do you think libhd is portable enough, not to suse-centric ? Any chance it
> works on solaris, *bsd, etc ?

Hrm. I wouldn't think it's suse-centric, but if it is, it's fixable, I guess. Solaris and *BSD are unlikely to work, though :/
Comment 4 Benoît Dejean 2009-05-13 20:29:37 UTC
I was sure this was hub's work !
I'm happy with the patch but i'm concerned by the dependency, but if you think it's acceptable (do you ?), i'll push ! 
Comment 5 Vincent Untz 2009-05-13 20:33:50 UTC
(In reply to comment #4)
> I was sure this was hub's work !
> I'm happy with the patch but i'm concerned by the dependency, but if you think
> it's acceptable (do you ?), i'll push ! 

Well, it needs to be proposed as an external dependency, I guess. Unless we make this code optional.

I honestly can't say what is the best solution since I didn't look closely at the code and at the library :/
Comment 7 Robert Roth 2012-12-08 00:59:07 UTC
System Monitor should monitor only dynamic data, hardware information is not really dynamic, but rather static, that is why even the System tab has been removed from System monitor (see bug #649908) and it's content moved to Control Center->Details->Overview.
Discussions regarding adding more hardware information are going on in control center bug #398036, so I am marking this as a duplicate of that one.
Besides this, the proposed branch (quite old) uses HAL (Hardware abstraction layer) which got deprecated in the meantime, so it should not be used anymore.

*** This bug has been marked as a duplicate of bug 398036 ***