After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582136 - category differentiation in desktop.lang
category differentiation in desktop.lang
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
2.6.x
Other All
: Normal minor
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-11 08:31 UTC by Karl Ostmo
Modified: 2009-11-26 15:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
Patch against desktop.lang of GtkSourceView version 2.6.1 (1.97 KB, patch)
2009-05-11 08:35 UTC, Karl Ostmo
none Details | Review
effect of patch on color scheme (76.46 KB, image/png)
2009-05-11 08:41 UTC, Karl Ostmo
  Details
updated patch of desktop.lang against git head (2.9.2?) (5.64 KB, patch)
2009-11-25 01:09 UTC, Karl Ostmo
none Details | Review

Description Karl Ostmo 2009-05-11 08:31:42 UTC
The freedesktop menu spec [1] distinguishes between 3 categories of menu items.  Highlighting the "reserved" category in a different color may help avoid Lintian errors [2] when creating Debian packages.

[1] - http://standards.freedesktop.org/menu-spec/1.0/apa.html
[2] - http://lintian.debian.org/tags/desktop-entry-uses-reserved-category.html

Other information:
Comment 1 Karl Ostmo 2009-05-11 08:35:03 UTC
Created attachment 134380 [details] [review]
Patch against desktop.lang of GtkSourceView version 2.6.1

This patch separates the 3 categories into different-colored groups.
Comment 2 Karl Ostmo 2009-05-11 08:41:14 UTC
Created attachment 134382 [details]
effect of patch on color scheme

"TrayIcon" is a reserved category; this color scheme makes it stand out.
Comment 3 Paolo Borelli 2009-05-16 15:32:09 UTC
Splitting the categories sounds good, but it has to wait the next releases since it adds new translated strings.

A couple of comments on the patch:
 - please create the patch with git format-patch or at least create it in the unuified format so that is readable (with "diff -u")
 - using "def:error" seems a bit excessive, as far as I uderstand those categories are reserved but may be used at some point and I'd prefer old installed version of gedit etc to not show them as errors
Comment 4 Ignacio Casal Quinteiro (nacho) 2009-11-15 01:10:47 UTC
Now that we can add new strings, Karl, do you think you could update your patch?
Comment 5 Karl Ostmo 2009-11-25 01:09:55 UTC
Created attachment 148424 [details] [review]
updated patch of desktop.lang against git head (2.9.2?)

As per Comment #3 I've replaced "def:error" with "def:note" and created the patch with the command "git format-patch origin".

For reference, here is the link to the latest "Registered Categories" spec:
http://standards.freedesktop.org/menu-spec/latest/apa.html
(it has not changed between version 1.0 and the current 1.1 spec)
Comment 6 Ignacio Casal Quinteiro (nacho) 2009-11-26 15:25:47 UTC
Patch pushed with minor fixes. Thanks a lot for it.