GNOME Bugzilla – Bug 581987
Incorrect Smart Playlist templates in localized Banshee
Last modified: 2009-06-04 14:06:44 UTC
Please describe the problem: When I run Banshee in French, Some predefined smart playlists have incorrect search criteria. For example Recently added has criterion "Album contains 'added<1 week ago'", instead of "Date added less than 1 week ago". I'm running the official Ubuntu Jaunty packet Steps to reproduce: 1. Set your locale to French 2. Launch Banshee without a database (I guess) 3. Select 'Properties' for the playlist "Récemment Ajoutés" Actual results: The search criterion is all messed up, so the playlist remains empty even if you add new tracks Expected results: The criterion should be set up right, so that the playlist would be useful Does this happen every time? Yes Other information:
This is also happening on git master.
Created attachment 134309 [details] Screenshot of the "recently added" smart playlist in french Here's what I get with fr_FR locale, after selecting the "Recently added" predefined playlist and clicking on the "Open in editor" button.
Created attachment 134344 [details] [review] Fixed time span queries It looks like (Relative)?TimeSpanQueryValue.FactorString() methods should not localise the strings they return. This patch fixes the problem, I tested it in fr_FR, nl_NL and en_AU locales.
Changing severity to Critical because the bug crashes Banshee in nl_NL locale. Steps to reproduce: 1. Delete the database 2. Switch to nl_NL 3. Start Banshee 4. Right click "Recentelijk toegevoegd" (recently added) and select "Slimme speellijst bewerken" (edit smart playlist) The patch above fixes the crash.
*** Bug 552009 has been marked as a duplicate of this bug. ***
Alex, the patch fixes the problem, but it breaks searches : For example, in fr_FR, typing temps<"1 heure" in the search box doesn't work anymore. Typing temps<"1 hour" still works. Looks like the FactorString method is also used to parse user queries, which can be in the current language.
Good catch Bertrand, I will fix this tomorrow...
Created attachment 134370 [details] [review] Fixed user searches This patch changes TimeSpanQueryValue.ParseUserQuery() to use both localised and invariant English terms.
With this patch, the original issue is fixed, and searches work. Thanks Alex, please commit to master.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
*** Bug 584663 has been marked as a duplicate of this bug. ***