After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581817 - Black screen when entering wrong password
Black screen when entering wrong password
Status: RESOLVED OBSOLETE
Product: vinagre
Classification: Applications
Component: VNC
2.26.x
Other Linux
: Normal normal
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-08 02:11 UTC by Bastien Nocera
Modified: 2011-04-17 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
First patch (36.74 KB, patch)
2009-09-18 17:02 UTC, Bastien Nocera
none Details | Review
updated patch (1.35 KB, patch)
2009-09-18 17:16 UTC, Bastien Nocera
needs-work Details | Review
updated patch (1.02 KB, patch)
2009-09-18 17:32 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2009-05-08 02:11:27 UTC
vinagre-2.24.2-1.fc10.x86_64
gtk-vnc-0.3.8-4.fc10.x86_64

(The 2 bugs roller into one might already be fixed...)

1. Launch vinagre
2. See the Mac in the "nearby hosts". avahi-browse -ra says:
= eth0 IPv4 Bastien Nocera’s Mac mini                   VNC Remote Access    local
   hostname = [bastien-noceras-mac-mini.local]
   address = [192.168.1.105]
   port = [5900]
   txt = []
3. Double-click on the bookmark
4. Black screen

Connecting via "Machine" -> "Connect" and entering the IP address correctly asks for a password.

2nd (related?) bug:
1. Launch vinagre
2. Machine -> Connect -> 192.168.1.105
3. Get asked for password, enter wrong password
4. Black screen, and no mentions that we entered the wrong password
Comment 1 Bastien Nocera 2009-05-08 12:01:29 UTC
The first bug is fixed trying out 2.26 in F11, the second one isn't.
Comment 2 Jonh Wendell 2009-08-01 19:06:50 UTC
Hi, Bastien. Please run vinagre in a terminal with the argument --gtk-vnc-debug and paste here the output. Thanks.
Comment 3 Bastien Nocera 2009-09-18 17:02:40 UTC
Created attachment 143459 [details] [review]
First patch

Let's start with that patch to make the activation of mDNS bookmarks 1) not emit warnings 2) actually get through to the signal handlers.
Comment 4 Bastien Nocera 2009-09-18 17:07:43 UTC
With the above patch, I don't get a request for a password when activating an mDNS bookmark:
gtk-vnc: Expose 0x1 @ 1468,892
gtk-vnc: Started background coroutine
gtk-vnc: Resolving host bastien-noceras-mac-mini.local 5900
gtk-vnc: Trying socket 19
gtk-vnc: Protocol initialization
gtk-vnc: Server version: 3.889
gtk-vnc: Using version: 3.8
gtk-vnc: Possible auth 30
gtk-vnc: Possible auth 31
gtk-vnc: Possible auth 32
gtk-vnc: Possible auth 2
gtk-vnc: Possible auth 35
gtk-vnc: Thinking about auth type 2gtk-vnc: Decided on auth type 2gtk-vnc: Waiting for auth type
gtk-vnc: Choose auth 2
gtk-vnc: Do Challenge
gtk-vnc: Requesting missing credentials
gtk-vnc: Set password credential milhouzegtk-vnc: Waiting for missing credentials
gtk-vnc: Got all credentials
gtk-vnc: Checking auth result
gtk-vnc: Expose 0x1 @ 1468,892

Using the IP address works though.
Comment 5 Bastien Nocera 2009-09-18 17:13:09 UTC
Patch applies to master as well.
Comment 6 Bastien Nocera 2009-09-18 17:16:51 UTC
Created attachment 143460 [details] [review]
updated patch

And you really need to add a real COPYING file to the tree too...
Comment 7 Jonh Wendell 2009-09-18 17:23:48 UTC
Comment on attachment 143460 [details] [review]
updated patch

The first two changes are OK, bu the last one no.

I want to explicitly pass NULL to the signal. The listener (vinagre-window.c:fav_panel_selected) checks if it is NULL to make some menu items sensitive or not.
Comment 8 Bastien Nocera 2009-09-18 17:30:01 UTC
NULL isn't a valid object.
Comment 9 Jonh Wendell 2009-09-18 17:31:14 UTC
Then we should back and pass just pointers to signals, agree?
Comment 10 Bastien Nocera 2009-09-18 17:32:34 UTC
Created attachment 143462 [details] [review]
updated patch

You're right, this patch fixes the warnings as expected.
Comment 11 Bastien Nocera 2009-09-18 18:26:21 UTC
Back to the original bug:
1. Connect to a VNC server with a password
2. Save the password in the keyring
3. Change the password in the keyring using seahorse (or change the remote password on the server)
4. Try to connect to the same VNC server
5. Black screen, and gtk-vnc only asks for authentication once

The log says:
gtk-vnc: Expose 0x1 @ 1468,892
gtk-vnc: Started background coroutine
gtk-vnc: Resolving host bastien-noceras-mac-mini.local 5900
gtk-vnc: Trying socket 19
gtk-vnc: Protocol initialization
gtk-vnc: Server version: 3.889
gtk-vnc: Using version: 3.8
gtk-vnc: Possible auth 30
gtk-vnc: Possible auth 31
gtk-vnc: Possible auth 32
gtk-vnc: Possible auth 2
gtk-vnc: Possible auth 35
gtk-vnc: Thinking about auth type 2
gtk-vnc: Decided on auth type 2
gtk-vnc: Waiting for auth type
gtk-vnc: Choose auth 2
gtk-vnc: Do Challenge
gtk-vnc: Requesting missing credentials
gtk-vnc: Set password credential BLAHBLAHBLAH
gtk-vnc: Waiting for missing credentials
gtk-vnc: Got all credentials
gtk-vnc: Checking auth result
gtk-vnc: Expose 0x1 @ 1468,892
gtk-vnc: Expose 0x1 @ 1468,892
gtk-vnc: Expose 0x1 @ 1468,892

<black screen>

gtk-vnc: Requesting that VNC close
gtk-vnc: Requesting graceful shutdown of connection
gtk-vnc: Waking up couroutine to shutdown gracefully

Does that look like a gtk-vnc bug?
gtk-vnc-0.3.9-1.fc12.x86_64
Comment 12 David King 2011-04-17 16:16:05 UTC
In Vinagre 2.30.3 with gtk-vnc 0.4.2 (and master of both) this seems to be fixed (an authentication error dialog is shown). Please reopen if you still see the problem.